feat(console): add HubSpot (Jitsu version) source to catalog (JITSU-82)#1376
Open
vklimontovich wants to merge 1 commit into
Open
feat(console): add HubSpot (Jitsu version) source to catalog (JITSU-82)#1376vklimontovich wants to merge 1 commit into
vklimontovich wants to merge 1 commit into
Conversation
Register jitsucom/source-hubspot in jitsuSources so the forked HubSpot connector (with CRM deletion capture) is selectable. Versions resolve from Docker Hub once the image is published. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YKm5MHND5s8hpWbVw8VoH
![jitsu-code-review[bot]](https://avatars.githubusercontent.com/in/3391383?s=60&v=4){kind=small}
| packageType: "airbyte", | ||
| meta: { | ||
| name: "HubSpot (Jitsu version)", | ||
| license: "ELv2", |
There was a problem hiding this comment.
This source is marked ELv2, but /api/sources/versions currently sets isMit = true for any package present in jitsuSources (pages/api/sources/versions.ts, else if (jitsuSources[packageId]) { isMit = true; }). Adding an ELv2 entry here makes that MIT flag incorrect, which can leak non-MIT versions into MIT-compliant filtering paths. Could we derive isMit from jitsuSources[packageId].meta.license (or mitVersions) instead of hard-coding all Jitsu sources as MIT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the forked HubSpot connector (
jitsucom/source-hubspot) in the source catalog so users canselect HubSpot (Jitsu version) — the fork adds deletion capture in incremental sync (archived
records emitted as
_ab_cdc_deleted_attombstones), which upstreamairbyte/source-hubspotcan't do.Adds a
JitsuHubspotSourceentry and registers it injitsuSources. Versions resolve live from DockerHub, so they appear once the image is published.
Depends on / cross-ref
jitsucom/source-hubspotimage before this is useful.Follow-up (not in this PR)
Migrate the existing "HubSpot Rex" sync config from
airbyte/source-hubspottojitsucom/source-hubspot(DB update) once the image is live.
🤖 Generated with Claude Code