fix: restore comment attachment to formal parameters, including JSNI comments#963
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
Prettier is allowed to attach comments to formal parameters nodes again. Printing of comments inside of empty formal parameters is also aligned more closely with Prettier JS/TS again.
Note that JSNI comments still cause the method definition's parameter list to be wrapped. This is not ideal, but is the way it was working previously, so this PR will be merged to restore JSNI support and a follow-on effort can attempt to fix the forced wrapping issue.
Example
Input
Output
Relative issues or prs:
Closes #957