RTECO-1651 - Update agent plugins tests - #3618
Draft
udaykb2 wants to merge 12 commits into
Draft
Conversation
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 27, 2026 08:52
08b7669 to
3d2cedd
Compare
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 27, 2026 09:23
3d2cedd to
3cce295
Compare
Contributor
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 29, 2026 11:36
3cce295 to
84a71f9
Compare
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 29, 2026 12:11
84a71f9 to
c7096cd
Compare
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 29, 2026 18:21
9ed0455 to
ae14475
Compare
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 29, 2026 18:30
ae14475 to
7a367be
Compare
Changed -test.agentPlugins (incorrect format) to -test.agentPlugins=true (correct format). Go test flags use single dash prefix with =value format. The test was being skipped before because the flag was not properly parsed, causing the exit code 1 failure in the workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 29, 2026 18:32
7a367be to
e43d891
Compare
1. Fix TestAgentPluginsInstallSpecificVersion JSON parsing error: - Changed manifest type from map[string]string to map[string]any - This allows parsing the 'skills' array field added to plugin.json 2. Fix TestAgentPluginsNoRepoConfigured repo auto-discovery: - Test was expecting failure when no repo configured - But repo auto-discovery now finds matching agentplugins repos - Updated test to verify error handling for non-existent repos instead Co-authored-by: Cursor <cursoragent@cursor.com>
…scope The install command defaults to --global scope when neither --global nor --project-dir is specified. Update the test to verify that explicit --project-dir flag works correctly instead of assuming a different default. This way we test production code as-is rather than changing production code to match incorrect test expectations. Co-authored-by: Cursor <cursoragent@cursor.com>
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 30, 2026 05:53
f3ec26a to
9990dab
Compare
Explicitly use bash shell for the test command to prevent PowerShell from interpreting the -test flag prefix. This fixes the 'flag provided but not defined: -test' error on Windows runners. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace loose OR-based error string checks with assertErrorContainsAll matched to production messages. Rewrite NoRepoConfigured to delete the agentplugins repo and assert ResolveRepo discovery failure. Require md5, sha1, and sha256 on checksum tests. Document marketplace install without marketplace slug syntax and keep multi-harness paths for cursor, claude, and codex. Co-authored-by: Cursor <cursoragent@cursor.com>
Search now captures JSON stdout and asserts name/version/repo, substring matching, latest-version-only rows, blank-query rejection, env-repo resolution, and the no-match log message. Delete asserts exact production errors, covers missing slug/version/env-repo paths, and verifies a missing version of an existing plugin fails without deleting the kept version. Co-authored-by: Cursor <cursoragent@cursor.com>
Assert list JSON rows for remote/local modes, limits, and exact flag/usage errors instead of smoke-only success checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove duplicate install/list/search smoke tests, assert JSON summaries and manifest fields, cover project-scope rejection for list/update, env repo resolution for install/update, and marketplace slug-not-listed errors. Co-authored-by: Cursor <cursoragent@cursor.com>
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 30, 2026 12:01
f3d7e64 to
c03e8c0
Compare
Cover install, list, check-updates, and update for an agent-config.json custom agent as a fifth harness case beyond the built-in four. Also fix three CI assertion mismatches: search no-match log buffer, update of an uninstalled plugin error text, and ValidateSemver rejection messages (now table-driven across patch/major/segment cases). Co-authored-by: Cursor <cursoragent@cursor.com>
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 30, 2026 13:23
c03e8c0 to
6857fff
Compare
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 30, 2026 15:22
7784be1 to
1e729b2
Compare
Omit --version on harness installs unless a specific older version must be pinned for update/check-updates scenarios. Custom agents still pass --version because they are not indexed into marketplace.json. Custom agent lifecycle covers install, list, and update end-to-end. Also bump jfrog-cli-artifactory to 659839816e66. Co-authored-by: Cursor <cursoragent@cursor.com>
udaykb2
force-pushed
the
RTECO-1651-update-plugins-e2e-tests
branch
from
July 30, 2026 15:29
1e729b2 to
1769983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....