RTECO-1574 - RTECO-1574 - Implementation of Nuget Support for client - - #3616
Draft
bhanurp wants to merge 2 commits into
Draft
RTECO-1574 - RTECO-1574 - Implementation of Nuget Support for client -#3616bhanurp wants to merge 2 commits into
bhanurp wants to merge 2 commits into
Conversation
**Source:** https://jfrog-int.atlassian.net/browse/RTECO-1574 - Start working on Nuget V2, V3 support for Nuget package manager in jfrog cli. - Make sure PRs are manageable and code is written in a way it can be reused across the clients - Add support for nugetV3 and nugetV2 - refer to [unsupported block: inlineCard] ## Things to consider while implementing - Use JFROG_CLI_NATIVE_IMPLEMENTATION support since nuget is already supported when this is set it routes via native package manager(flexpack). - BuildInfo collection in build-info-go - check sum calculation - Original Deployment Repository calculation - Requested By calculation for dependencies - Easy authentication using nuget’s credentials like mentioned in above Atlassian wiki. - Build Info collection for both dependencies and artifacts for all the commands eligible listed in above wiki. - Set properties clearly on artifacts published. - Make sure the buildinfo is figuring out and showing show in tree in build info section when published to artifactory. ## Not to implement - nuget-config support is not required since this is flexpack implementation. **Parent:** RTECO-395 **Components:** jfrog-cli-nuget Task: RTECO-1574
- Only resolve/require server details for FlexPack NuGet commands that actually need them (push with a deploy repo, or restore with a resolve repo), instead of unconditionally requiring a --server-id for every subcommand. - Renamed --repo-deploy to --repo and --allow-insecure-connections to --insecure-tls to match the flags actually documented/used elsewhere. - Added getNugetCommandName to correctly treat dotnet's two-token "nuget push" as a single push subcommand, instead of misclassifying it. - Replaced the temporary local-filesystem-path go.mod replaces for build-info-go and jfrog-cli-artifactory (committed by mistake in the previous commit on this branch) with proper pseudo-version pins against their latest pushed RTECO-1574 commits, which fix: packages.config checksum/scope/cache-miss gaps, the flat NuGet push storage path assumption that broke property stamping, a restore-vs-push module identity mismatch that split one project into two disconnected build-info modules, missing .slnx solution support, and a missing --source flag that made every native push fail outright. Verified live against a real Artifactory server, building purely from the pinned remote commits (no local path replaces).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by workbench RTECO-1574.
RTECO-1574 - Implementation of Nuget Support for client -
Source: https://jfrog-int.atlassian.net/browse/RTECO-1574
Things to consider while implementing
Not to implement
Parent: RTECO-395
Components: jfrog-cli-nuget
Evidence: see Artifactory bundle for RTECO-1574.
Jira: https://jfrog-int.atlassian.net/browse/RTECO-1574