JGC-499 - Remove concurrency from reusable test suites#3549
Merged
Conversation
When invoked via workflow_call, each suite's `concurrency` group resolves using the caller's context (github.workflow = "Build Gate"), so all suites and the parent run share one identical group. With cancel-in-progress: true they cancelled each other before starting, leaving only frogbot (which has no concurrency block) to run and making build-gate-success fail on cancelled needs. The orchestrator's own concurrency already supersedes older runs per PR/branch, so the per-suite blocks are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the post-merge
Build Gaterun onmaster(#3535), where onlyfrogbotran andbuild-gate-successfailed immediately because every test suite was cancelled before starting.Root cause
Each reusable suite still declared its own:
When a workflow is invoked via
workflow_call,github.workflowresolves to the caller (Build Gate), so all 25 suites and the parent run compute the same concurrency group. Withcancel-in-progress: truethey cancelled one another (and collided with the parent) before starting.frogbotsurvived only because it has noconcurrencyblock. With all suites cancelled,build-gate-success(if: always()) ran and failed oncontains(needs.*.result, 'cancelled').Fix
Remove the
concurrency:block from the 25 reusable suite workflows. The orchestrator (build-gate.yml) keeps its ownconcurrency, which already supersedes older runs per PR/branch — so cancellation behaviour is preserved without the self-collision.Validation
105 deletions(-)); no logic changed.