Open
Conversation
attiasas
added
ignore for release
github-actions
bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(jas): pass Xray version to Analyzer Manager via JF_XRAY_VERSIONSummary
GetAnalyzerManagerXscEnvVarsnow takes the current Xray version and always injects it into the JAS / Analyzer Manager environment asJF_XRAY_VERSION. Audit and binary scan flows pass the resolved version from command parameters; malicious scan passes an empty version with an updated argument list. Tests are updated for the new parameter and expected env map shape.Changes
jas/common.go: ExtendGetAnalyzerManagerXscEnvVarswithxrayVersion string; includeJF_XRAY_VERSIONin the base env map.jas/analyzermanager.go: Add constantjfXrayVersionEnvVariable(JF_XRAY_VERSION).commands/audit/audit.go: PassauditParams.GetXrayVersion()intoGetAnalyzerManagerXscEnvVars.commands/scan/scan.go: PassscanCmd.xrayVersionfor binary JAS scans.commands/maliciousscan/maliciousscan.go: Adjust call for the new parameter (empty Xray version).jas/common_test.go(struct field, expectations, row for non-empty version);jas/runner/jasrunner_test.go(extra""argument).