Pick correct diff baseline when multiple technologies share a path Summary#724
Open
Pick correct diff baseline when multiple technologies share a path Summary#724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

devbranch.go vet ./....go fmt ./....fix(audit): pick correct diff baseline when multiple technologies share a path
Summary
In audit diff mode, baseline scan results were matched by relative path only. When two technologies scanned the same directory (same absolute path, empty relative key), the wrong baseline could be chosen depending on iteration order. Matching now also considers the current target’s technology (with legacy behavior preserved when technology is unset).
Changes
SearchTargetResultsByRelativePathto accepttechnologyand filter candidates viatargetMatchesTechnologyForDiffCompare(utils/results/common.go).targetResult.Technologythrough audit diff comparison and JASGetResultsToCompareByRelativePath(commands/audit/audit.go,jas/common.go).NoTechbaseline compatibility (utils/results/common_test.go,jas/common_test.go).Notes
technologyisNoTech, behavior matches the previous path-only matching.