Skip to content

Revert "feat(perf): Beasties critical CSS — homepage-only (#335)"#336

Merged
pftg merged 1 commit into
masterfrom
revert/sprint-3c-beasties
May 11, 2026
Merged

Revert "feat(perf): Beasties critical CSS — homepage-only (#335)"#336
pftg merged 1 commit into
masterfrom
revert/sprint-3c-beasties

Conversation

@pftg
Copy link
Copy Markdown
Member

@pftg pftg commented May 11, 2026

Why

User reports the Beasties homepage critical-CSS inlining (#335) caused design regression that wasn't caught by bin/dtest's 84-screenshot baseline. Reverting to restore known-good state immediately.

What this reverts

  • package.json + bun.lockb: drops beasties devDependency
  • bin/hugo-build: removes the bin/inline-critical invocation block
  • bin/inline-critical + bin/inline-critical.mjs: deleted
  • Net: 5 files changed, 127 deletions

What this does NOT undo

Investigation followup (separate work)

The visual regression bin/dtest didn't catch the broken design. Two possible explanations to investigate:

  1. The broken design is on a page or viewport not in the 84-screenshot baseline set.
  2. Beasties' inline critical CSS extraction skipped a selector that mattered for the page state being measured.

Either way: the test gate wasn't broad enough. Future similar work should expand bin/dtest coverage to include the affected page/viewport BEFORE the implementation sprint, not after.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Simplified the production build process by removing critical CSS inlining optimization, streamlining the overall build pipeline.
    • Removed an associated build tool dependency to reduce project overhead.

Review Change Stack

@pftg pftg merged commit 7160cb1 into master May 11, 2026
2 checks passed
@pftg pftg deleted the revert/sprint-3c-beasties branch May 11, 2026 06:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1b6b39f5-24fe-4f74-9dfa-027198dacf0f

📥 Commits

Reviewing files that changed from the base of the PR and between 56cdc72 and b7046f2.

⛔ Files ignored due to path filters (1)
  • bun.lockb is excluded by !**/bun.lockb
📒 Files selected for processing (4)
  • bin/hugo-build
  • bin/inline-critical
  • bin/inline-critical.mjs
  • package.json

📝 Walkthrough

Walkthrough

This PR removes the critical CSS inlining feature from the build pipeline. The beasties CSS processor, its Node implementation, the bash wrapper, and its invocation from the Hugo build are all deleted. The build now skips critical CSS inlining entirely when running in production.

Changes

Critical CSS Inlining Removal

Layer / File(s) Summary
Build Orchestration
bin/hugo-build
The production-only call to inline-critical that ran after Hugo build is removed.
Bash Entrypoint
bin/inline-critical
The entire bash script that validated the target public directory and invoked the Node processor is deleted.
Processor Implementation
bin/inline-critical.mjs
The Node script that configured Beasties, rewrote stylesheet URLs for processing, and inlined critical CSS into index.html is completely removed.
Dependency Cleanup
package.json
The beasties development dependency is removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A build without the critical glow,
One less tool in the pipeline's flow—
CSS inlining takes a bow,
The page builds simpler now. 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/sprint-3c-beasties

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant