ci: remove dead nix-version matrix from cli-tests test job#2869
Closed
mikeland73 wants to merge 1 commit into
Closed
ci: remove dead nix-version matrix from cli-tests test job#2869mikeland73 wants to merge 1 commit into
mikeland73 wants to merge 1 commit into
Conversation
The `test` job defined a 3-value `nix-version` matrix, but the value was never wired into any step after the job switched to installing Nix via devbox-install-action (which can't pin a Nix version). The three legs ran identical duplicates, tripling the slowest/flakiest job for no extra coverage. Remove the matrix and document how to re-add it once the install action supports specifying a Nix version. Cross-version coverage remains in the separate test-nix-versions job. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines CI by removing an unused nix-version matrix from the test job in cli-tests.yaml. Since the job now installs Nix via jetify-com/devbox-install-action (which doesn’t allow pinning a specific Nix version), the matrix legs were redundant and only increased runtime/flakiness without adding coverage.
Changes:
- Removed the unused
nix-versionmatrix from thetestjob to eliminate duplicate job runs. - Added an in-file note documenting why the matrix was removed and how to reintroduce it if version pinning becomes available.
- Kept cross-version Nix coverage in the dedicated
test-nix-versionsjob (unchanged).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikeland73
added a commit
that referenced
this pull request
Jun 15, 2026
…y-cicd-tests Brings in #2869: remove the dead nix-version matrix from the cli-tests test job (the install action no longer pins a Nix version, so the legs were identical duplicates). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Folded into #2868 (merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testjob incli-tests.yamldefined a 3-valuenix-versionmatrix, but the value was never referenced in any step after #1839 switched the job to installing Nix viadevbox-install-action(which can't pin a Nix version) — so the three legs ran identical duplicates, tripling the slowest and flakiest job for zero extra coverage. This PR removes the matrix and leaves a comment explaining how to re-add it once the install action supports specifying a Nix version. Cross-version coverage is still provided by the separatetest-nix-versionsjob, and this cuts thetestjob from 6 → 2 runs per PR.Note
The
testjob names lose their nix-version suffix (e.g.test (not-main, ubuntu-latest, project-tests-off)); branch protection required-checks may need updating to match.How was it tested?
CI on this PR; no test logic changed (only redundant matrix legs removed).
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.