Fix visual glitches when moving a rebase todo - #5977
Merged
Conversation
This option has no effect, it isn't respected by refreshRebaseCommits, so it looks misleading to include it here.
Now that we have PostRefreshUpdateWithOptions there's no reason to offer a bespoke method for setting one particular option.
This fixes two problems: 1. the list selection updated before the list content did, which caused a bit of a wobble effect in the list 2. the main view would first update to a different commit's diff and then back to the one that is being moved, resulting in a very ugly flicker especially when moving the todo multiple times with auto repeat
stefanhaller
force-pushed
the
fix-flicker-when-moving-rebase-todo
branch
from
August 29, 2026 15:26
5393776 to
3914755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems: