Fix broken commit auto-scrolling - #5972
Merged
Merged
Conversation
stefanhaller
added
the
ignore-for-release
Drag autoscrolling deliberately keeps rendering after the test action has returned, so view bounds can change while the test goroutine prepares its next mouse event. Snapshot the geometry on the event loop before translating view-relative coordinates to avoid data races. This hasn't been a problem so far, but only because we were lucky; the added test assertions later in this branch would cause consistent race detector failures without this fix.
When dragging a commit with auto-scrolling so that the original commit leaves the viewport, dragging back into the view makes the original commit snap back into view. This is a regression that was introduced by aebf495.
During auto-scrolling, turn off the automatic scroll-to-make-the-selected-item-visible functionality of PostRefreshUpdate.
stefanhaller
force-pushed
the
fix-broken-commit-autoscrolling
branch
from
August 27, 2026 06:25
098fade to
35753fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug introduced in #5928: dragging a commit with auto-scrolling so that the original commit leaves the viewport, and then dragging back into the view would snap the original commit back into view.
Labeled as ignore-for-release because it's a regression in a PR that wasn't released yet.