Support job-dsl native syntax for folder-scoped github app credentials#1529
Open
justusbunsi wants to merge 1 commit into
Open
Support job-dsl native syntax for folder-scoped github app credentials#1529justusbunsi wants to merge 1 commit into
justusbunsi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes allows users to easily define folder-scoped github app credentials via job-dsl plugin. Without it, users would have to use the all-mighty "configure" callback to add those settings by xml modification. Sample job-dsl of what now works:
I am not sure if you want a test for this, and if it is even possible. Let me know if it is. I am happy to add one.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify