-
-
Notifications
You must be signed in to change notification settings - Fork 49
feat(generate): add json-schema for a CLI's config file #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| use std::path::PathBuf; | ||
|
|
||
| use miette::IntoDiagnostic; | ||
|
|
||
| use crate::cli::generate; | ||
| use crate::schema::{config_schema, SchemaOptions}; | ||
| use crate::Result; | ||
|
|
||
| /// Generate a JSON Schema for a CLI's config file from its usage spec | ||
| #[derive(clap::Args)] | ||
| #[clap()] | ||
| pub struct JsonSchema { | ||
| /// A usage spec taken in as a file, use "-" to read from stdin | ||
| #[clap(short, long)] | ||
| file: Option<PathBuf>, | ||
|
|
||
| /// Write the schema here instead of to stdout | ||
| #[clap(long, value_hint = clap::ValueHint::FilePath)] | ||
| out_file: Option<PathBuf>, | ||
|
|
||
| /// raw string spec input | ||
| #[clap(long, required_unless_present = "file", overrides_with = "file")] | ||
| spec: Option<String>, | ||
|
|
||
| /// The schema's title, shown by editors | ||
| #[clap(long)] | ||
| title: Option<String>, | ||
|
|
||
| /// Where the schema is published, for its `$id` | ||
| #[clap(long)] | ||
| url: Option<String>, | ||
| } | ||
|
|
||
| impl JsonSchema { | ||
| pub fn run(&self) -> Result<()> { | ||
| let spec = generate::file_or_spec(&self.file, &self.spec)?; | ||
| let options = SchemaOptions { | ||
| title: self | ||
| .title | ||
| .clone() | ||
| .or_else(|| Some(format!("{} configuration", spec.name))), | ||
| url: self.url.clone(), | ||
| }; | ||
| let schema = config_schema(&spec.config, &options); | ||
| // A schema with no properties and `unevaluatedProperties: false` rejects every config | ||
| // file there is, which is worse than saying there is nothing to describe. Asked of | ||
| // the schema rather than of the spec, because a spec whose settings are *all* | ||
| // `scope="env"` declares props and still has nothing a file may hold. | ||
| if schema | ||
| .get("properties") | ||
| .and_then(serde_json::Value::as_object) | ||
| .is_none_or(serde_json::Map::is_empty) | ||
| { | ||
| miette::bail!( | ||
| "this spec declares nothing a config file can hold, so there is no schema to write" | ||
| ); | ||
| } | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| let json = serde_json::to_string_pretty(&schema).into_diagnostic()?; | ||
| // Through the shared writer, like every other generator: it takes `-` for stdout and | ||
| // reports a broken pipe instead of panicking on one. | ||
| generate::write_or_stdout(self.out_file.as_deref(), &format!("{json}\n"))?; | ||
| Ok(()) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.