Skip to content

feat: make iterators bidirectional - #1473

Merged
SGSSGene merged 2 commits into
jbeder:masterfrom
sxrzh:fix1192-bidirectional-iterator
Aug 1, 2026
Merged

feat: make iterators bidirectional#1473
SGSSGene merged 2 commits into
jbeder:masterfrom
sxrzh:fix1192-bidirectional-iterator

Conversation

@sxrzh

@sxrzh sxrzh commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Makes YAML::detail::node_iterator_base and YAML::detail::iterator_base bidirectional.
Closes #1192 .

@sxrzh

sxrzh commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

I also implemented rbegin, rend functions and reverse_iterator, const_reverse_iterator type aliases. Should I merge them here?

@SGSSGene

SGSSGene commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

I also implemented rbegin, rend functions and reverse_iterator, const_reverse_iterator type aliases. Should I merge them here?

Wow! Cool! Great work!

Please keep them separat. The smaller a PR the more likley I find the time to proper review and merge.

@SGSSGene
SGSSGene merged commit 3eb39d5 into jbeder:master Aug 1, 2026
46 checks passed
@sxrzh

sxrzh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Note that decrement_until_defined is not guarded. This could only be triggered by UB like --begin(), and meets the requirements of C++ standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can iterator_base be changed to bidirectional?

2 participants