Skip to content

fix: move test to correct location - #1462

Merged
SGSSGene merged 1 commit into
jbeder:masterfrom
SGSSGene:fix/move_test
Aug 1, 2026
Merged

fix: move test to correct location#1462
SGSSGene merged 1 commit into
jbeder:masterfrom
SGSSGene:fix/move_test

Conversation

@SGSSGene

@SGSSGene SGSSGene commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

@sxrzh mentions in PR #1427 the wrong location of the tests.
This PR moves the tests and applies adjustments to fit the structure of the tests in those directories.

@sxrzh

sxrzh commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Thank you! The tests are now in the right location.
I think SetVerbatimTag in emitter_test.cpp should be EmitSetVerbatimTag for consistency (That was my fault in #1427).
By the way, it seems that a trailing \n in emitter_test.cpp was accidentally removed. I don't know whether this matters.

@sxrzh

sxrzh commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@SGSSGene

@SGSSGene

SGSSGene commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator Author

Thank you! The tests are now in the right location. I think SetVerbatimTag in emitter_test.cpp should be EmitSetVerbatimTag for consistency (That was my fault in #1427). By the way, it seems that a trailing \n in emitter_test.cpp was accidentally removed. I don't know whether this matters.

@sxrzh Good catch, changed it to EmitSetVerbatimTag.
I added a trailing \n that was missing in the file.

For answering a different comment about files line endings:
POSIX specs requires every line of a text file to end with a newline character, for some reasons the default of visual studio code doesn't add a newline character. (It should really be named 'end of line' character 😅)

@SGSSGene
SGSSGene merged commit 7239989 into jbeder:master Aug 1, 2026
46 checks passed
@SGSSGene
SGSSGene deleted the fix/move_test branch August 1, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants