You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sxrzh mentions in PR #1427 the wrong location of the tests.
This PR moves the tests and applies adjustments to fit the structure of the tests in those directories.
Thank you! The tests are now in the right location.
I think SetVerbatimTag in emitter_test.cpp should be EmitSetVerbatimTag for consistency (That was my fault in #1427).
By the way, it seems that a trailing \n in emitter_test.cpp was accidentally removed. I don't know whether this matters.
Thank you! The tests are now in the right location. I think SetVerbatimTag in emitter_test.cpp should be EmitSetVerbatimTag for consistency (That was my fault in #1427). By the way, it seems that a trailing \n in emitter_test.cpp was accidentally removed. I don't know whether this matters.
@sxrzh Good catch, changed it to EmitSetVerbatimTag.
I added a trailing \n that was missing in the file.
For answering a different comment about files line endings: POSIX specs requires every line of a text file to end with a newline character, for some reasons the default of visual studio code doesn't add a newline character. (It should really be named 'end of line' character 😅)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sxrzh mentions in PR #1427 the wrong location of the tests.
This PR moves the tests and applies adjustments to fit the structure of the tests in those directories.