Conversation
|
For context, googletest does not specify a range, which is why the minimum matters there. |
bcaca6d to
35ad556
Compare
|
@henryiii How did you image testing with distinct versions of CMake? Downloading and building CMake from source seems excessive. |
|
I do it in pybind11 and CLI11 (local support action). Basically |
f698b0c to
4e3c06b
Compare
|
I removed a maximum version, just requiring 3.15 seems the saner choice for now. Two points are left:
|
|
Thank you for updating this PR, I will take a look at it this week.
Github does not provide a runner for ubuntu 26.04. Please use 24.04 or pick any other image, see https://github.com/actions/runner-images |
|
What does this mean, relicensing? |
|
CMake is designed to always have an upper version due to its policy system. Upper versions keep newer CMake versions working longer. Setting a minimum version of 3.15 and not setting an upper version might start throwing a warning at some point in the near future. Be setting an upper version too, say to 4.0, should work for many many more years. The policies will be set to 3.15 if you don't set an upper version. While they will be set to the highest version that CMake supports up until the upper version if you set an upper version. So as long as CMake supports whatever value is in the upper version as its minimum version, it will still work. 3.4...3.15 doesn't show a warning today, for example, because CMake does know how to build stuff for 3.15 without a warning. While 3.4 by itself can't be used, because CMake doesn't have those policies anymore |
|
Sure, I'll leave that to @SGSSGene to decide. But there was some discussion about relicensing? |
4e3c06b to
33d173f
Compare
Yes. I copied the file |
Ensure that oldest supportest version of CMake can configure project Copy quick_cmake from CLIUtils/CLI11
|
You have my permission, certainly. |
33d173f to
4da4169
Compare
|
Ah, that's fine, it's pretty small and straightforward code. |
Uh oh!
There was an error while loading. Please reload this page.