fix(theme-store): use injected get() to break circular self-reference

[hognek]

Task: t_71a7eb3a

Replace the useThemeStore.getState() call inside the theme-store create closure with the get() argument injected by zustand's create. This eliminates the TS7022 / TS7006 cascade caused by referencing the store within its own initializer.

Changed:

• create<ThemeStore>((set) => ({...})) -> create<ThemeStore>((set, get) => ({...}))
• getWallpapersBySection now uses get() instead of useThemeStore.getState()

Only the in-closure occurrence changes. Module-level getState() calls in exported helpers (outside the creator) keep referencing the hook directly — they are not circular.

Verification:

• tsc -b --force exits 0 (full uncached typecheck, no TS7022/TS7006)
• vitest run src/stores/theme-store.test.ts src/stores/__tests__/wallpaper.test.ts: 19/19 pass

Summary by CodeRabbit

• Refactor
  • Improved theme state handling when generating wallpaper sections.
  • No visible changes to the user experience.

[github-actions]

👋 Thanks for the PR! This one targets master, which is our
stable branch (it's what live installs track). Please retarget it to
dev — click Edit next to the PR title and change the base
branch dropdown from master to dev. Your commits and any review
carry over, nothing is lost.

See CONTRIBUTING.md for the branch model.

[gitar-bot]

Gitar is working

_Gitar

[qodo-code-review]

PR Summary by Qodo

Fix theme store circular self-reference by using zustand-injected get()

🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Use zustand’s injected get() inside the store initializer to avoid self-referencing the store.
• Eliminate TS7022/TS7006 typecheck failures without changing external helper patterns.

Diagram

graph TD
  UI["Theme consumers"] --> Hook["useThemeStore"] --> Init["create<ThemeStore>(...) initializer"]
  Init --> GetFn["injected get()"] --> Selector["getWallpapersBySection()"] --> Data["WALLPAPERS"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Move derived logic to a pure helper taking state as an argument

• ➕ Keeps store initializer free of any intra-store reads
• ➕ Makes derivations easier to unit test in isolation
• ➖ Adds indirection and may duplicate state-shape typing at call sites
• ➖ Doesn’t address other potential circular reads if added later

2. Define store creator with an explicit `StateCreator` type alias

• ➕ Can reduce inference cascades in more complex stores
• ➕ Makes the intended set/get API explicit in types
• ➖ More boilerplate for a single call-site issue
• ➖ Doesn’t change the underlying circular reference risk if getState() is still used inside initializer

Recommendation: Keep the PR’s approach. Using zustand’s injected get() is the idiomatic fix for avoiding circular self-references during store initialization, and it minimizes surface-area change while directly addressing the TS7022/TS7006 cascade.

Files changed (1) +2 / -2

Bug fix (1) +2 / -2

theme-store.tsUse zustand-injected 'get()' inside store initializer +2/-2

Use zustand-injected 'get()' inside store initializer

• Updates the zustand 'create' initializer signature to accept 'get' and switches 'getWallpapersBySection' to read state via 'get()' rather than 'useThemeStore.getState()'. This prevents referencing the store hook within its own initialization and avoids the resulting TypeScript inference/error cascade.

desktop/src/stores/theme-store.ts

[kilo-code-bot]

Code Review Summary

Status: No New Issues Found | Recommendation: Merge

Files Reviewed (1 files)

• desktop/src/stores/theme-store.ts - No new issues in this incremental diff

Previous Review Summaries (2 snapshots, latest commit 04574bb)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 04574bb)

Status: No New Issues Found | Recommendation: Merge

Files Reviewed (1 files)

• desktop/src/stores/theme-store.ts - No new issues in this incremental diff

Previous review (commit 1743609)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)

• desktop/src/stores/theme-store.ts

---

_{Reviewed by step-3.7-flash · Input: 44.2K · Output: 2.5K · Cached: 257.2K}

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (1)

Context used

✅ Compliance rules (platform): 35 rules

✅ Skills: taos-development-skill

1. No new regression test 📜 Skill insight ▣ Testability

Description

This PR fixes a bug in useThemeStore initialization by switching to the injected get() accessor,
but it does not add any new test case that would fail prior to the fix and pass after it. Without a
regression test, this typecheck/circular-reference issue may be reintroduced unnoticed.

Code

desktop/src/stores/theme-store.ts[229]

+export const useThemeStore = create<ThemeStore>((set, get) => ({

Relevance

●● Moderate

Tests are frequently accepted when suggested, but no clear precedent enforcing new regression test
for every bugfix.

PR-#1542
PR-#507

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

PR Compliance ID 2185285 requires that bug-fix PRs add at least one regression test. The diff shows
only the fix in desktop/src/stores/theme-store.ts (switching the create closure to accept get
and using get() in getWallpapersBySection) with no accompanying test change in the provided PR
diff.

desktop/src/stores/theme-store.ts[229-229]
desktop/src/stores/theme-store.ts[305-307]
Skill: taos-development-skill

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR is a bug fix but does not include a new regression test that would catch the circular self-reference/type inference failure (TS7022/TS7006) if it reappears.

## Issue Context
The change replaces `useThemeStore.getState()` inside the zustand `create` closure with the injected `get()` to avoid self-referencing the store during initialization.

## Fix Focus Areas
- desktop/src/stores/theme-store.test.ts[1-200]
- desktop/src/stores/theme-store.ts[229-307]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[qodo-code-review]

1. No new regression test 📜 Skill insight ▣ Testability

This PR fixes a bug in useThemeStore initialization by switching to the injected get() accessor,
but it does not add any new test case that would fail prior to the fix and pass after it. Without a
regression test, this typecheck/circular-reference issue may be reintroduced unnoticed.

Agent Prompt

## Issue description
The PR is a bug fix but does not include a new regression test that would catch the circular self-reference/type inference failure (TS7022/TS7006) if it reappears.

## Issue Context
The change replaces `useThemeStore.getState()` inside the zustand `create` closure with the injected `get()` to avoid self-referencing the store during initialization.

## Fix Focus Areas
- desktop/src/stores/theme-store.test.ts[1-200]
- desktop/src/stores/theme-store.ts[229-307]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

[jaylfc]

Reviewed. ON-SPEC, arming. Correct fix and the right idiom.

getWallpapersBySection called useThemeStore.getState() from INSIDE the store's own initializer, which is a circular self-reference: the module binding is not initialised while create() is still running, so the call depends on module-evaluation order rather than on anything the code controls. Swapping to zustand's injected get() is the standard fix and is semantically identical for callers - same state object, no behaviour change - while removing the cycle.

Verified rather than eyeballed: 191 tests across all 16 store suites pass with the change, including restore-theme.test.ts which is the one that would notice if getWallpapersBySection started returning a different shape.

No changelog needed (internal correctness fix, no user-visible behaviour change) and doc-gate agrees - it is not red. CI is otherwise clean on this one.

Auto-merge armed on green.

[coderabbitai]

📝 Walkthrough

Walkthrough

The theme store initializer now receives Zustand’s get accessor. Wallpaper-section generation uses this accessor to read current store state.

Changes

Theme store state access

Layer / File(s)	Summary
Use initializer-scoped state access desktop/src/stores/theme-store.ts	The store initializer accepts get. getWallpapersBySection uses get() instead of useThemeStore.getState().

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: jaylfc

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: using the injected Zustand get() function to remove the theme-store circular self-reference.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[jaylfc]

recreate-cla

[hognek]

Pushed empty commit to retrigger CLA check.

[hognek]

I have read the CLA Document and I hereby sign the CLA

[jaylfc]

recreate-cla

[hognek]

recreate-cla

[jaylfc]

recreate-cla

[jaylfc]

Refreshing CI against the current base (dev moved 14 times since these checks ran). The cla check cannot structurally appear on this PR (fork PRs do not fire pull_request_target on synchronize, and the comment-triggered run binds to the default branch); hognek's CLA signature is on record in cla-signatures, so this will merge on fresh green with a documented gate exception.

[jaylfc]

Merging with the cla check absent, documented exception: fork PRs cannot fire pull_request_target on synchronize (measured earlier today), and the comment-triggered run binds to the default branch, so cla is structurally unable to appear here. hognek's CLA signature is verified in the cla-signatures branch (signatures/version1/cla.json), which satisfies the check's actual purpose. All other required checks are green on the current head after the close/reopen refresh; base drift since those runs is one docs-only merge (#2327).