Remove unused default constructor in threadpool.h to fix AI finding#3698
Open
softins wants to merge 1 commit into
Open
Remove unused default constructor in threadpool.h to fix AI finding#3698softins wants to merge 1 commit into
softins wants to merge 1 commit into
Conversation
The default constructor leaves a member uninitialised, and is not needed.
pljones
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Removes the unneeded default constructor for CThreadPool
CHANGELOG: SKIP
Context: Fixes an issue?
AI code review correctly deduced that the default constructor leaves class members uninitialised, specifically
stop.This default constructor is never used within Jamulus, and the proper constructor
CThreadPool(size_t)correctly does initialisestop.Supersedes and closes #3686
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Tested and ready
What is missing until this pull request can be merged?
Nothing
Checklist