Skip to content

JamulusPlus#3689

Draft
AndyMcProducer wants to merge 29 commits into
jamulussoftware:mainfrom
AndyMcProducer:JamulusPlus
Draft

JamulusPlus#3689
AndyMcProducer wants to merge 29 commits into
jamulussoftware:mainfrom
AndyMcProducer:JamulusPlus

Conversation

@AndyMcProducer
Copy link
Copy Markdown

Short description of changes

Adds JamulusPlus, a JUCE/VST-based Jamulus fork/variant with an alternate plugin-style UI and extended client-side features. This includes a separate resizable settings window, chat stability fixes, clickable chat links, VDO.Ninja room launch from the connected server name, upload bandwidth display, jitter handling fixes, and optional local auto-translation for incoming chat.

CHANGELOG: SKIP

Context: Fixes an issue?

Context: This Pull Request proposes an experimental Jamulus-based variant aimed at plugin-oriented workflows and expanded UI/chat functionality. It does not directly fix a single upstream issue and is better understood as a feature branch proposal for discussion and review.

Does this change need documentation? What needs to be documented and how?

Yes. If this approach is accepted, the following would need documentation:

  • what JamulusPlus is and how it differs from the standard Jamulus client
  • how to build it, including JUCE/VST-related dependencies and the JUCE submodule
  • how the separate settings window works
  • how chat auto-translation works and that translations are local-only
  • how VDO.Ninja room launch works from the connected server name/address
  • any platform or plugin-host limitations

This would likely require both developer/build documentation and user-facing documentation on the website if the feature is accepted upstream.

Status of this Pull Request

Working implementation

What is missing until this pull request can be merged?

  • maintainer feedback on whether upstream wants to include and maintain a parallel JamulusPlus variant
  • architectural review of dependency, maintenance, and packaging impact
  • broader testing across supported platforms and plugin hosts
  • CI/build validation for all affected targets
  • documentation
  • possible breakup into smaller focused PRs if only parts of this work are suitable for upstreaming

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see
Copy link
Copy Markdown
Member

ann0see commented May 14, 2026

wants to include and maintain a parallel JamulusPlus variant

not me at least. But we can obviously benefit a lot from using some changes from it

Comment thread libs/NSIS/NSIS-source/makensisw.exe Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding exe files is a definite nogo on git.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I put em as zip's then?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K ann0see I've done that, off out now so have to check when they build when I'm back.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I got ya now, i thought you meant on the relase but maybe that's sneaked on, ill do a further cleanup of it to make sure none of that is there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think they are downloaded as dependencies in the current version of Jamulus. Adding any kind of binaries is a smell in git for various reasons including security - e.g checkout the XZ vulnerability.

Copy link
Copy Markdown
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'd focus on seeing changes to the current code and work from there on.

@AndyMcProducer
Copy link
Copy Markdown
Author

Remember this is all your work/s. Most has been pulled and QT stuff converted and I added some extras but I do plan on using AI to attribute things properly it have pulled over or converted.
Reason I wanted to add it as a branch then it's their for all to be able to poke at and change etc between yourselves.
I haven't done a proper test but atm I'm getting to a server 26ms though this one and 33 on current Jamulus.
I've added the jitter etc but doesn't seem to do much on low ping servers as it's low anyway.
Not sure if this is a biproduct of Juce compared to QT.
But mainly if ya pull it in and ya can rip , stuff or change it up to how ya want.
I added a customisable theme system in it too, should be a template folder with skin.cfg with how to's in there.

but anyway I'm not looking to step on toes of even join the main project, just thought this would help you all out
and allow for better tweaks with out being stuck to QT.

It's up to you guys though, the source will always be their to pull form it if ya want, all's cool.
Andy.

@ann0see
Copy link
Copy Markdown
Member

ann0see commented May 15, 2026

Yes. That's all fine but the current state is unfortunately not reviewable as it looks like a totally separate codebase.

@AndyMcProducer
Copy link
Copy Markdown
Author

AndyMcProducer commented May 15, 2026 via email

@mcfnord
Copy link
Copy Markdown
Contributor

mcfnord commented May 15, 2026

The whole project sounds interesting and I'd like to see screen shots. This detail is big if true so I'm just amplifying it:

I'm getting to a server 26ms though this one and 33 on current Jamulus.

@AndyMcProducer
Copy link
Copy Markdown
Author

AndyMcProducer commented May 15, 2026 via email

@AndyMcProducer
Copy link
Copy Markdown
Author

AndyMcProducer commented May 15, 2026 via email

@AndyMcProducer
Copy link
Copy Markdown
Author

AndyMcProducer commented May 15, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants