JamulusPlus#3689
Conversation
- Settings dialog opens without crash - GUI visible immediately on open - Settings dialog closes without crash - Audio routing with 48kHz sample rate conversion (LinearResampler) - GlobalEventFilter only blocks focus events on embedded window - Windows-level InvalidateRect/UpdateWindow for forced repainting
…nts, and Fixed Master Peak Meters
not me at least. But we can obviously benefit a lot from using some changes from it |
There was a problem hiding this comment.
Adding exe files is a definite nogo on git.
There was a problem hiding this comment.
Should I put em as zip's then?
There was a problem hiding this comment.
K ann0see I've done that, off out now so have to check when they build when I'm back.
There was a problem hiding this comment.
Ah I got ya now, i thought you meant on the relase but maybe that's sneaked on, ill do a further cleanup of it to make sure none of that is there.
There was a problem hiding this comment.
No. I think they are downloaded as dependencies in the current version of Jamulus. Adding any kind of binaries is a smell in git for various reasons including security - e.g checkout the XZ vulnerability.
ann0see
left a comment
There was a problem hiding this comment.
Thank you. I'd focus on seeing changes to the current code and work from there on.
|
Remember this is all your work/s. Most has been pulled and QT stuff converted and I added some extras but I do plan on using AI to attribute things properly it have pulled over or converted. but anyway I'm not looking to step on toes of even join the main project, just thought this would help you all out It's up to you guys though, the source will always be their to pull form it if ya want, all's cool. |
|
Yes. That's all fine but the current state is unfortunately not reviewable as it looks like a totally separate codebase. |
|
Ok, yeah maybe it leaked on from my local, ill check for any more and link instead.
…________________________________
From: ann0see ***@***.***>
Sent: 15 May 2026 13:23
To: jamulussoftware/jamulus ***@***.***>
Cc: AndyMc ***@***.***>; Author ***@***.***>
Subject: Re: [jamulussoftware/jamulus] JamulusPlus (PR #3689)
@ann0see commented on this pull request.
________________________________
On libs/NSIS/NSIS-source/makensisw.exe<#3689 (comment)>:
No. I think they are downloaded as dependencies in the current version of Jamulus. Adding any kind of binaries is a smell in git for various reasons including security - e.g checkout the XZ vulnerability.
—
Reply to this email directly, view it on GitHub<#3689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB64GYNWS7CBH4PDWVQ6VQD424D5JAVCNFSM6AAAAACY6EB75KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEOJYGA2TKMBUGU>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
The whole project sounds interesting and I'd like to see screen shots. This detail is big if true so I'm just amplifying it:
|
|
I'm on another machien now so ill test it again on here.
…________________________________
From: John Dempsey ***@***.***>
Sent: 15 May 2026 16:40
To: jamulussoftware/jamulus ***@***.***>
Cc: AndyMc ***@***.***>; Author ***@***.***>
Subject: Re: [jamulussoftware/jamulus] JamulusPlus (PR #3689)
[https://avatars.githubusercontent.com/u/1750243?s=20&v=4]mcfnord left a comment (jamulussoftware/jamulus#3689)<#3689 (comment)>
The whole project sounds interesting and I'd like to see screen shots. This detail is big if true so I'm just amplifying it:
I'm getting to a server 26ms though this one and 33 on current Jamulus.
—
Reply to this email directly, view it on GitHub<#3689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB64GYNKHABETZP7PEEE4J3424277AVCNFSM6AAAAACY6EB75KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINRRGE3TGOJYHE>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I should have set a better skin but ya should be able to see it fine. Same device and buffer and audio setting.
https://github.com/user-attachments/assets/ee4db510-c502-4e62-970f-9d0735e4c928
https://github.com/user-attachments/assets/f3a98222-8c53-474a-95ae-7488097989c1
Screen shots, didn't let me just add as images added normal html image tags but they never worked.
…_____________
From: Andy McCance ***@***.***>
Sent: 15 May 2026 16:50
To: jamulussoftware/jamulus ***@***.***>
Subject: Re: [jamulussoftware/jamulus] JamulusPlus (PR #3689)
I'm on another machien now so ill test it again on here.
________________________________
From: John Dempsey ***@***.***>
Sent: 15 May 2026 16:40
To: jamulussoftware/jamulus ***@***.***>
Cc: AndyMc ***@***.***>; Author ***@***.***>
Subject: Re: [jamulussoftware/jamulus] JamulusPlus (PR #3689)
[https://avatars.githubusercontent.com/u/1750243?s=20&v=4]mcfnord left a comment (jamulussoftware/jamulus#3689)<#3689 (comment)>
The whole project sounds interesting and I'd like to see screen shots. This detail is big if true so I'm just amplifying it:
I'm getting to a server 26ms though this one and 33 on current Jamulus.
—
Reply to this email directly, view it on GitHub<#3689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB64GYNKHABETZP7PEEE4J3424277AVCNFSM6AAAAACY6EB75KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINRRGE3TGOJYHE>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Thanks for pointing this out, it had not ignored stuff it was meant to. Sorting it now though so it's all sorted. Plus nsis isn't used now inno installer it.
So will be a lot cleaner soon. Thank you dude for pointing that out. xx
…________________________________
From: ann0see ***@***.***>
Sent: 15 May 2026 13:23
To: jamulussoftware/jamulus ***@***.***>
Cc: AndyMc ***@***.***>; Author ***@***.***>
Subject: Re: [jamulussoftware/jamulus] JamulusPlus (PR #3689)
@ann0see commented on this pull request.
________________________________
On libs/NSIS/NSIS-source/makensisw.exe<#3689 (comment)>:
No. I think they are downloaded as dependencies in the current version of Jamulus. Adding any kind of binaries is a smell in git for various reasons including security - e.g checkout the XZ vulnerability.
—
Reply to this email directly, view it on GitHub<#3689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB64GYNWS7CBH4PDWVQ6VQD424D5JAVCNFSM6AAAAACY6EB75KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEOJYGA2TKMBUGU>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Short description of changes
Adds
JamulusPlus, a JUCE/VST-based Jamulus fork/variant with an alternate plugin-style UI and extended client-side features. This includes a separate resizable settings window, chat stability fixes, clickable chat links, VDO.Ninja room launch from the connected server name, upload bandwidth display, jitter handling fixes, and optional local auto-translation for incoming chat.CHANGELOG: SKIP
Context: Fixes an issue?
Context: This Pull Request proposes an experimental Jamulus-based variant aimed at plugin-oriented workflows and expanded UI/chat functionality. It does not directly fix a single upstream issue and is better understood as a feature branch proposal for discussion and review.
Does this change need documentation? What needs to be documented and how?
Yes. If this approach is accepted, the following would need documentation:
JamulusPlusis and how it differs from the standard Jamulus clientThis would likely require both developer/build documentation and user-facing documentation on the website if the feature is accepted upstream.
Status of this Pull Request
Working implementation
What is missing until this pull request can be merged?
JamulusPlusvariantChecklist