fix: win: disable IME on VM control window - #117
Open
foresee-io wants to merge 2 commits into
Open
Conversation
Signed-off-by: Zhenyu FU <ysfcore@outlook.com>
There was a problem hiding this comment.
🟡 Changes recommended
The current IME-disabling call is missing the required <imm.h> include and may not actually affect the focused render child window that receives keyboard input.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to fix Windows VM control window keyboard passthrough issues (Issue #116) by disabling the host IME context so IME composition and IME-switch shortcuts aren’t intercepted by the host while interacting with the VM display.
Changes:
- Link against
imm32to use IME APIs on Windows. - Call
ImmAssociateContextEx(hwnd, NULL, 0)during window creation to detach the IME context from the IDD display window.
File summaries
| File | Description |
|---|---|
| src/backend_win/vm_display_idd.c | Disables IME context (via imm32) for the IDD display window to improve raw keyboard passthrough behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Zhenyu FU <ysfcore@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable IME context on VM control window.
Fix issue #116