Added timeperiods for Monitors#1939
Conversation
steven-geo
commented
Jul 2, 2026
- Added time periods for Monitors - following same methodology as alerters. This is now the MAINT (Maintenance) Status.
- When in maintenance the last_result shows the time configuration for the monitor.
- Allow Days of week to be entered as text (Mon-Sun, Monday to Sunday) as well as numerical. (Monitors and Alerters)
- HTML Template updated to show monitors in maintenance in bd_primary colour type, and count at top of screen.
- Updated Documentation
- Add Time Testing to Monitors (test_monitor.py)
- Incremented version to 1.15.1
Co-authored-by: steven <steven.github@geoclay.net>
Co-authored-by: steven <steven.github@geoclay.net>
* Fix tls_expiry monitor showing as OLD * Updated age column to show age of any 'old' status objects as well as remote Co-authored-by: steven <steven.github@geoclay.net>
* Added time periods for Monitors - following same methodology as alerters. This is now the MAINT (Maintenance) Status. * When in maintenance the last_result shows the time configuration for the monitor. * Allow Days of week to be entered as text (Mon-Sun, Monday to Sunday) as well as numerical. (Monitors and Alerters) * HTML Template updated to show monitors in maintenance in bd_primary colour type, and count at top of screen. * Updated Documentation * Add Time Testing to Monitors (test_monitor.py) * Incremented version to 1.15.1
|
Looks like tests may have failed due to transient DNS and other issues, can we re-run and try again. linting, env-test and unit-test pass locally on python 3.13. |
|
Yes, the 3rd party I pointed the TLS smoke tests at rate-limits them (which is fair). I've re-run the failing ones and will look properly later :) |
|
Different Error this time. Looks like it got passed the DNS errors on the first run. REF: ERROR (simplemonitor.logger-network) Failed to send network data: Object of type MonitorTimeFilter is not JSON serializable |
|
Seeing an actual issue now when it tries to serialise the time filter thing for a remote instance (not dug in to the code yet, sorry for the imprecise summary): |
* Added time periods for Monitors - following same methodology as alerters. This is now the MAINT (Maintenance) Status. * When in maintenance the last_result shows the time configuration for the monitor. * Allow Days of week to be entered as text (Mon-Sun, Monday to Sunday) as well as numerical. (Monitors and Alerters) * HTML Template updated to show monitors in maintenance in bd_primary colour type, and count at top of screen. * Updated Documentation * Add Time Testing to Monitors (test_monitor.py) * Incremented version to 1.15.1
|
|
||
| import arrow | ||
|
|
||
| from ..Monitors.monitor import MonitorTimeFilter |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1939 +/- ##
===========================================
- Coverage 69.93% 68.92% -1.02%
===========================================
Files 49 50 +1
Lines 4690 4923 +233
===========================================
+ Hits 3280 3393 +113
- Misses 1410 1530 +120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Serialization resolved. Will work through codecov stuff tomorrow (late here). I think the Windows 3.11 test is still failing with a DNS issue though. |