Skip to content

ci: align npm publish workflow with npm OIDC docs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baransu merged 1 commit into from
May 25, 2026
Merged

ci: align npm publish workflow with npm OIDC docs #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
startsWith(github.event.release.tag_name, 'v'))
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: "22"
node-version: "24"

@devin-ai-integration devin-ai-integration Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Volta-pinned Node version diverges significantly from CI

The package.json:60-62 pins Node to 18.19.0 via Volta, while this workflow now uses Node 24. This was already a mismatch before the PR (Node 22 vs Volta 18), but the gap is widening. If any dependency or build step relies on Volta's pinned version semantics, the CI publish environment may behave differently from local development. This is a pre-existing inconsistency but worth being aware of.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

registry-url: "https://registry.npmjs.org"
- name: Install dependencies
run: npm ci
Expand Down
Loading