Skip to content

Drop attachment captions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bilb wants to merge 1 commit into from
Closed

Drop attachment captions #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions include/session/client/attachment.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ struct OutgoingAttachment {
/// local file is a temporary whose name means nothing to the recipient.
std::optional<std::string> filename;

/// Text shown with the attachment. Distinct from the message body, which is shown as its own
/// message.
std::optional<std::string> caption;

/// Marks this as a recorded voice message rather than an ordinary audio file, which clients
/// present differently.
bool voice_message = false;
Expand Down Expand Up @@ -149,7 +145,6 @@ struct Attachment {

std::optional<std::string> content_type;
std::optional<std::string> filename;
std::optional<std::string> caption;

/// A recorded voice message rather than an ordinary audio file, which clients present
/// differently.
Expand Down
123 changes: 38 additions & 85 deletions proto/SessionProtos.pb.cc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading