Merged
Conversation
- Add CLAUDE.md documenting project layout, architecture, EP pattern, Temporal PHP FQCNs, coding standards, and useful paths. - Add .claude/skills/ with scaffolding skills for official Temporal PHP patterns the plugin already recognizes: workflow, activity, signal, query, update, child-workflow, saga, schedule, worker, starter, test.
- intellij-plugin-dev: general JetBrains SDK reference split into topic files (structure, extensions, services, threading, psi, indexes, inspections, actions-ui, gradle, kotlin) sourced from the official IntelliJ Platform SDK documentation. - kotlin-dev: project-specific conventions layered on top of the platform skill (common/languages packages, EP pattern, PHP mixins, naming, perf). - kotlin-test: JUnit 4 + IntelliJ Platform Test Framework recipes for inspections, indexes, and pure-logic tests.
Covers all production code currently shipped by the plugin: - MixinTest — PhpClass.isActivity/isWorkflow, Method.isActivity/isWorkflow tolerance rules, hasAttribute FQN matching (7 cases). - PhpActivityMethodInspectionTest — warning detection + quick-fix application (4 cases). - PhpActivityMethodUsageInspectionTest — warning at the call site for missing #[ActivityMethod] attributes (3 cases). - PhpActivityClassIndexTest / PhpActivityMethodIndexTest / PhpWorkflowClassIndexTest / PhpWorkflowMethodIndexTest — file-based index coverage (class + method, with/without attribute, negative cases). Infrastructure: - TemporalPhpTestCase base class wires VfsRootAccess for src/test/resources and pre-copies a Temporal PHP stubs file so #[ActivityInterface], #[ActivityMethod], #[WorkflowInterface] etc. resolve to the same FQNs TemporalClasses.kt declares. - Switch test IDE target from IntelliJ IDEA to PhpStorm so the PHP plugin and its file type are registered during tests (PHP is bundled in PhpStorm; com.jetbrains.php is now listed as a bundled plugin instead of a marketplace plugin). 21 tests, all green.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporal PHP FQCNs, coding standards, and useful paths.
patterns the plugin already recognizes: workflow, activity, signal,
query, update, child-workflow, saga, schedule, worker, starter, test.