fix(captures): serialize webgl requests to prevent memory leak when doing bulk captures and always clean up#37
Open
jnccloud wants to merge 3 commits intoitschip:mainfrom
Open
fix(captures): serialize webgl requests to prevent memory leak when doing bulk captures and always clean up#37jnccloud wants to merge 3 commits intoitschip:mainfrom
jnccloud wants to merge 3 commits intoitschip:mainfrom
Conversation
fix(webgl): serialize requests for webgl to accommodate for chromium …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chromium by default only has 16 contexts and is supposed to handle it on its own, but I was running into frequent issues (out of game memory) and sluggish behavior during bulk capture sessions (aka green screens). this maintained my capture rate at about 1 per second for clothing items and I no longer suffered from out of game memory errors.