Validate Enzyme gradient for cyl hmap#46
Open
krystophny wants to merge 19 commits into
Open
Conversation
Member
Author
|
Fixed the cyl AD fixture failure here: the Enzyme fixture now compiles with the selected fixed hmap, uses a cyl parameter file for The non-flat hmaps stay out of this fixture until their zeta-dependent hmap context is exported. The blockers are listed in the PR body for |
0e5c9e0 to
fd3b3d0
Compare
fd3b3d0 to
6a1b84e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13.
Hmap Scope
This PR covers
GVEC_FIX_HMAP=RZandGVEC_FIX_HMAP=cyl.The remaining fixed hmaps need separate flat contexts before the same Enzyme fixture can cover them:
axisNB: the metric depends on zeta-dependent axis and frame data such asX0,T,N,B, frame derivatives, and cross products held in the axisNB auxvar, including data loaded from the hmap NetCDF input.frenet: the metric depends on the Frenet auxiliary arrayslp,kappa,tau,sigma, their derivatives, and the zeta-dependentX0/T/N/Bframe, including frame-switch handling.knot: the metric is not the RZ/cyl scalar specialization; it needs the knot parameters and zeta-dependent trigonometric metric terms exported to a separate flat kernel.Verification
Test fails before fix
Command, run at the parent commit:
Output excerpt:
Test passes after fix
Command:
Output:
Command:
Output:
Command:
Output excerpts:
Command:
Output:
Command:
Output: