Enable kill_request filter in the proxy build - #7210
Conversation
The `kill_request` extension has `enabled_default = False` in its Envoy BUILD file, so listing it in `extensions_build_config.bzl` alone is not enough — it compiles as an empty target. Add the Bazel flag to `.bazelrc` so the filter is actually included in the binary.
|
The issue here is: We think we are building with this extension, since it's in the |
|
@kyessenov can you recall why it's disabled in the past? |
|
That extension was added in Envoy disabled by default: envoyproxy/envoy#14170 - A new mechanism to enable it was added after that: envoyproxy/envoy#14240 In istio/proxy this extension was always included in our configuration since day 0, but it's not built by default unless a build flag is specified. This PR adds this build flag. My intention is to avoid confusion when reading the Given it was never enabled in Istio, I think the best approach then is just remove it from WDYT? |
The
kill_requestextension hasenabled_default = Falsein its Envoy BUILD file, so listing it inextensions_build_config.bzlalone is not enough — it compiles as an empty target. Add the Bazel flag to.bazelrcso the filter is actually included in the binary.