Skip to content

Enable kill_request filter in the proxy build - #7210

Open
jwendell wants to merge 1 commit into
istio:masterfrom
jwendell:enable-kill-request-filter
Open

Enable kill_request filter in the proxy build#7210
jwendell wants to merge 1 commit into
istio:masterfrom
jwendell:enable-kill-request-filter

Conversation

@jwendell

@jwendell jwendell commented Aug 5, 2026

Copy link
Copy Markdown
Member

The kill_request extension has enabled_default = False in its Envoy BUILD file, so listing it in extensions_build_config.bzl alone is not enough — it compiles as an empty target. Add the Bazel flag to .bazelrc so the filter is actually included in the binary.

The `kill_request` extension has `enabled_default = False` in its Envoy
BUILD file, so listing it in `extensions_build_config.bzl` alone is not
enough — it compiles as an empty target. Add the Bazel flag to
`.bazelrc` so the filter is actually included in the binary.
@jwendell
jwendell requested a review from a team as a code owner August 5, 2026 16:49
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2026
@jwendell

jwendell commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

The issue here is: We think we are building with this extension, since it's in the extensions_build_config.bzl file, but we need this flag in addition. This PR fixes this mistake. Alternatively we could simply remove that extension, but I think the original intention was to include it.

@zirain

zirain commented Aug 6, 2026

Copy link
Copy Markdown
Member

@kyessenov can you recall why it's disabled in the past?

@jwendell

Copy link
Copy Markdown
Member Author

That extension was added in Envoy disabled by default: envoyproxy/envoy#14170 - A new mechanism to enable it was added after that: envoyproxy/envoy#14240

In istio/proxy this extension was always included in our configuration since day 0, but it's not built by default unless a build flag is specified.

This PR adds this build flag.

My intention is to avoid confusion when reading the extensions_build_config.bzl file. One might think this extension is enabled when in fact it isn't.

Given it was never enabled in Istio, I think the best approach then is just remove it from extensions_build_config.bzl.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants