[release-1.31] Use UInt32Value for min_cluster_size to fix client-go JSON apply - #3756
Merged
Merged
Conversation
…io#3754) UInt64Value serializes as a JSON string (proto3 JSON spec) but the DestinationRule CRD schema declares minClusterSize as type: integer, so DRs containing it are rejected by the API server when applied via client-go, while kubectl apply works because it bypasses protobuf marshaling. UInt32Value serializes as a JSON number, matching the schema. A host count with a default of 6 does not require uint64 range.
istio-testing
added
the
size/XS
sschepens
added
the
release-notes-none
Member
Author
|
/retest |
Member
Author
|
@jewertow we would need to get this into 1.31 before release, since it's an api change |
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
jewertow
changed the title
jewertow
approved these changes
Aug 14, 2026
zirain
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manual cherry-pick of #3754 into 1.31
Fixes #3755