Document IndexedDB delete/read sync boundary#56
Open
issackjohn wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR documents the delete/read synchronization boundary in the IndexedDB TodoMVC workload and makes the “previous page” transition conditional on the configured iteration count instead of a hard-coded constant, aligning the control flow with the workload’s loop bounds.
Changes:
- Replace the hard-coded
j < 9guard withj < numberOfIterations - 1for the delete loop’s previous-page transition. - Add inline documentation explaining why the previous-page read does not race the just-triggered delete writes, and that the suite still waits for all deletes via
FinishDeletingItemsFromDB. - Mirror the same update into the built
distcopy of the workload.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| experimental/javascript-wc-indexeddb/src/workload-test.mjs | Removes hard-coded iteration boundary for delete paging and documents the delete/read sync boundary. |
| experimental/javascript-wc-indexeddb/dist/src/workload-test.mjs | Propagates the same boundary fix and documentation to the distribution artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for local issue 53.
This documents the delete/read synchronization boundary in the IndexedDB workload and removes the hard-coded
9page-transition check.Research summary:
TodoApp.moveToPreviousPage()awaitstodo-list.moveToPreviousPage()before dispatchingprevious-page-loaded.todo-list.moveToPreviousPage()awaitsstorageManager.getTodos(...), soprevious-page-loadedmeans the previous page read has completed.FinishDeletingItemsFromDBstill waits for all delete transactions before the suite advances.Validation:
git diff --checkNote: local Node/npm tooling was not available in this shell, so browser CI should cover the end-to-end validation.