Skip to content

Adds RMQ operators ArgoCd configs for prod#294

Merged
Sahil-STFC merged 4 commits into
mainfrom
#293-Add-RMQ-operators-to-Prod
May 18, 2026
Merged

Adds RMQ operators ArgoCd configs for prod#294
Sahil-STFC merged 4 commits into
mainfrom
#293-Add-RMQ-operators-to-Prod

Conversation

@Sahil-STFC
Copy link
Copy Markdown
Collaborator

closes: #293

@Sahil-STFC Sahil-STFC requested review from a team as code owners May 15, 2026 08:45
Copy link
Copy Markdown
Contributor

@ACLay ACLay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These configs seem to have quite a few differences to the ones in the management-dev directory.

Those specify a cluster to deploy to that's one (or potentially both depending on what the generators enable) of our cloud or isis microk8s clusters, while these are only deploying to https://kubernetes.default.svc, which I think would be the cluster where we run argocd, and I've a feeling that that's the management clusters and would make rabbitmq inaccessible to our apps

@Sahil-STFC Sahil-STFC requested a review from ACLay May 18, 2026 11:22
Copy link
Copy Markdown
Contributor

@ACLay ACLay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the environments consistent, should we also move the dev versions of these files from argocd/management-dev to argocd/dev/shared?

Comment on lines +14 to +15
# Uncomment if you want to deploy to dev-microk8s-alternative
#- name: dev-microk8s-alternative
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce the risk of misconfiguration in the future, could the commented out cluster names in these files be updated to prod-fallback instead of the dev value?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

…hared , updated the commented code in configsfor prod -fallback in
@Sahil-STFC Sahil-STFC requested a review from ACLay May 18, 2026 12:01
@Sahil-STFC Sahil-STFC merged commit a55ca90 into main May 18, 2026
@Sahil-STFC Sahil-STFC deleted the #293-Add-RMQ-operators-to-Prod branch May 18, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RMQ operators to Prod

4 participants