Skip to content

#326: place-name search works — point facets_url at rebuilt sample_facets_v4 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdhyee merged 2 commits into from
Jul 10, 2026
Merged

#326: place-name search works — point facets_url at rebuilt sample_facets_v4 #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e900a0
#326: point facets_url at sample_facets_v4 — place_name search now works
rdhyee Jul 10, 2026
04806dc
#326: raise smoke search budget 90s→150s — facets grew 62.5→69.4 MB
rdhyee Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion explorer.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ lite_url = `${R2_BASE}/isamples_202608_samples_map_lite_v3.parquet`
// pinning the version here keeps staging and prod each self-consistent.
wide_url = `${R2_BASE}/isamples_202608_wide.parquet`
// v2 carries object_type alongside material and context (URI-string columns).
facets_url = `${R2_BASE}/isamples_202608_sample_facets_v3.parquet`
facets_url = `${R2_BASE}/isamples_202608_sample_facets_v4.parquet`
facet_summaries_url = `${R2_BASE}/isamples_202608_facet_summaries.parquet`
// Pre-aggregated single-filter cache for fast cross-filtered facet counts.
cross_filter_url = `${R2_BASE}/isamples_202608_facet_cross_filter.parquet`
Expand Down
18 changes: 14 additions & 4 deletions tests/test_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,20 @@ def _on_console(msg):
const t = (el && el.textContent || '').trim();
return t && !/Searching/i.test(t) && /result/i.test(t);
}""",
# Aligned with the perf test's 90s search budget — a cold
# DuckDB-WASM query + remote parquet fetch on a slow CI
# runner can exceed 60s without the build being broken.
timeout=90_000,
# Liveness budget, not a latency SLA. A cold DuckDB-WASM query
# must download the FULL facets parquet on CI (the #190
# range-request fallback), then ILIKE-scan it; on a slow shared
# runner 90s was already marginal for broad terms like
# "pottery", and the #326 place-name rebuild grew the file
# 62.5→69.4 MB (real place strings), which pushed borderline
# runners over: the same commit passed this gate at 06:20 and
# failed it twice ~07:15 on 2026-07-10. 150s keeps the gate
# meaningful (dead search wiring still fails fast via the
# pageerror/fatal-console asserts below) without flaking on
# runner variance. Search *latency* is tracked separately
# (#167 perf instrumentation, #190 fallback, #169–#172 FTS as
# the real fix).
timeout=150_000,
)
results_text = page.locator("#searchResults").inner_text().strip()

Expand Down
Loading