Apply reused render product configuration on first execution - #783
Open
sylvesterkaczmarek wants to merge 7 commits into
Open
Apply reused render product configuration on first execution#783sylvesterkaczmarek wants to merge 7 commits into
sylvesterkaczmarek wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure
IsaacCreateRenderProductapplies the requested camera and resolution immediately when reusing an existing render product.The reuse path previously returned as soon as it accepted
inputs:renderProductPrim. That bypassed the common camera/resolution update path below it, so a supplied render product with stale settings could be reported as ready for one evaluation before being corrected on a later tick.The reuse path now applies
inputs:width,inputs:height, andinputs:cameraPrimbefore returning and synchronizes the cached state with those values.Validation
/OmniverseKit_Persp/OmniverseKit_Top