Validate RTX lidar render product before camera lookup - #779
Open
sylvesterkaczmarek wants to merge 5 commits into
Open
Validate RTX lidar render product before camera lookup#779sylvesterkaczmarek wants to merge 5 commits into
sylvesterkaczmarek wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix prerequisite validation in
ROS2RtxLidarHelperso missing stages and not-yet-created render products are handled as retryable conditions.The helper checked
stage.GetPrimAtPath(render_product_path) is None, but USD returns an invalidUsd.Primfor a missing path. That allows execution to continue intoViewportManager.get_camera()with a render product that does not exist.The helper also dereferenced the stage without guarding the case where no USD stage is available yet.
This change:
IsValid()Validation
ViewportManager.get_camera()is not called prematurelypy_compileandgit diff --check