Fix ROS2 RTX radar helper lifecycle guards - #776
Open
sylvesterkaczmarek wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two early lifecycle guards in
OgnROS2RtxRadarHelper.First, the helper checked
state.initializedbeforeinputs:enabled. Once initialized, disabling the node therefore returned immediately without callingcustom_reset(), leaving its writer state active.Second, the helper tested
stage.GetPrimAtPath(render_product_path) is None. USD returns an invalidUsd.Primfor a missing path rather thanNone, so the intended retry guard did not catch a render product that had not been created yet.The helper now:
enabled=falsefirst and resets initialized stateIsValid()before camera lookupValidation
custom_reset()ViewportManager.get_camera()