Skip to content

Honor explicit stage in HeightmapImporter - #772

Open
sylvesterkaczmarek wants to merge 2 commits into
isaac-sim:mainfrom
sylvesterkaczmarek:fix/heightmap-stage-targeting
Open

Honor explicit stage in HeightmapImporter#772
sylvesterkaczmarek wants to merge 2 commits into
isaac-sim:mainfrom
sylvesterkaczmarek:fix/heightmap-stage-targeting

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Description

Ensure HeightmapImporter(stage=...) consistently authors heightmap state into the stage supplied by the caller.

The importer accepted an explicit stage and used it for most geometry, but two operations bypassed it:

  • _setup_stage_properties() called the global stage utility for the up axis
  • _create_ground_plane() constructed GroundPlane, whose implementation targets the globally current USD stage

This change sets the up axis directly on self._stage and authors the ground plane with PhysicsSchemaTools.addGroundPlane(self._stage, ...).

Validation

  • adds an in-memory-stage regression test for stage units and up axis
  • existing heightmap creation tests now assert stage-targeted calls
  • ground-plane sizing/centering tests continue to cover square, wide, tall, offset, empty, and disabled cases
  • production change is limited to the heightmap importer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant