Update ROS2 joint state menu graph to use state reader - #767
Open
sylvesterkaczmarek wants to merge 3 commits into
Open
Update ROS2 joint state menu graph to use state reader#767sylvesterkaczmarek wants to merge 3 commits into
sylvesterkaczmarek wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Tools > Robotics > ROS 2 OmniGraphs > Joint States generator to use
IsaacReadJointStateas the source forROS2PublishJointState.ROS2PublishJointStatenow treats its directtargetPrimpath as deprecated and recommends connectingIsaacReadJointState. The maintained MoveIt example already follows that path, while the menu generator still creates the legacy graph.The generated publisher graph now:
isaacsim.sensors.physics.IsaacReadJointStateROS2PublishJointStateexecOutIsaacReadSimulationTimenode from this graphSubscriber/controller generation remains unchanged.
Validation
IsaacReadJointStatepy_compileandgit diff --checkAddresses the graph-template portion of #688 (internal ticket 6426353).