Use Patch instead of Update for interface config in NX-OS - #473
Open
felix-kaestner wants to merge 1 commit into
Open
Use Patch instead of Update for interface config in NX-OS#473felix-kaestner wants to merge 1 commit into
felix-kaestner wants to merge 1 commit into
Conversation
EnsureInterface now uses sb.Patch (gNMI update/merge) for all interface configuration objects instead of sb.Update (gNMI replace). This prevents the operator from clobbering interface config written by other automation (e.g. an OpenStack driver agent) that manages the same interface subtree concurrently. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnsureInterface now uses sb.Patch (gNMI update/merge) for all
interface configuration objects instead of sb.Update (gNMI replace).
This prevents the operator from clobbering interface config written
by other automation (e.g. an OpenStack driver agent) that manages
the same interface subtree concurrently.