Add OpenConfig DNS provider implementation - #471
Open
rgildein wants to merge 2 commits into
Open
Conversation
Implement EnsureDNS and DeleteDNS for the OpenConfig provider targeting SR Linux via gNMI. Maps DNSSpec.Domain to /system/dns/config/search and DNSSpec.Servers to /system/dns/servers/server list. Rejects unsupported fields (adminState: Down, sourceInterfaceName, vrfName) with explicit UnsupportedFieldError. Signed-off-by: Robert Gildein <rgildein@users.noreply.github.com>
rgildein
marked this pull request as ready for review
August 4, 2026 08:59
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Contributor
There was a problem hiding this comment.
As we already validate the expected payload through the testdata file in test/gnmi/testdata/openconfig/dns.txt, I think we can just leave out the Payload tests here in this internal/provider/openconfig/ package.
So generally, I would only add a dns_test.go if you really have some logic that you would want to test. One could e.g. add a table driven test func for the validateDNSSpec func, but other than that, I don't see much that would be worth a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement EnsureDNS and DeleteDNS for the OpenConfig provider targeting SR Linux via gNMI. Maps
DNSSpec. Domainto/system/dns/config/searchandDNSSpec.Serversto/system/dns/servers/serverlist.Rejects unsupported fields (adminState: Down, sourceInterfaceName, vrfName) with explicit UnsupportedFieldError.
How I tested it