Skip to content

Feat/multi provider support - #470

Draft
sven-rosenzweig wants to merge 2 commits into
mainfrom
feat/multi_provider_support
Draft

Feat/multi provider support#470
sven-rosenzweig wants to merge 2 commits into
mainfrom
feat/multi_provider_support

Conversation

@sven-rosenzweig

Copy link
Copy Markdown
Contributor

No description provided.

Replace 'openconfig' with 'openconfig.networking.metal.ironcore.dev'.

Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
@sven-rosenzweig
sven-rosenzweig force-pushed the feat/multi_provider_support branch 2 times, most recently from 53dcecf to 31d11c8 Compare July 30, 2026 11:21
Controllers look up the provider by name at reconcile time.
The startup flag becomes optional.
Resources that reference a device inherit the device's provider implicitly,
so the correct OS-level driver is selected automatically.

Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
@sven-rosenzweig
sven-rosenzweig force-pushed the feat/multi_provider_support branch from 31d11c8 to f2aed7d Compare July 30, 2026 11:48
@github-actions github-actions Bot added size/L and removed size/XL labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 1.78% (ø)
github.com/ironcore-dev/network-operator/cmd 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 64.14% (-0.92%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 60.94% (-0.71%) 👎
github.com/ironcore-dev/network-operator/internal/provider 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr 36.07% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 9.56% (ø)
github.com/ironcore-dev/network-operator/internal/provider/openconfig 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/provisioning 75.41% (-0.74%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/device_types.go 48.48% (ø) 33 16 17
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 2 0 2
github.com/ironcore-dev/network-operator/cmd/main.go 0.00% (ø) 297 (-8) 0 297 (-8)
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller.go 52.67% (-0.29%) 243 (+7) 128 (+3) 115 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/system_controller.go 64.23% (-1.29%) 123 (+7) 79 (+3) 44 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/vpcdomain_controller.go 77.10% (-1.54%) 214 (+8) 165 (+3) 49 (+5) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/aaa_controller.go 0.00% (ø) 146 (+7) 0 146 (+7)
github.com/ironcore-dev/network-operator/internal/controller/core/acl_controller.go 57.43% (-0.72%) 148 (+7) 85 (+3) 63 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/banner_controller.go 57.95% (-0.03%) 176 (+7) 102 (+4) 74 (+3) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/bgp_controller.go 68.44% (-0.76%) 244 (+7) 167 (+3) 77 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/bgp_peer_controller.go 57.75% (-0.32%) 329 (+7) 190 (+3) 139 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/certificate_controller.go 58.02% (-0.68%) 162 (+7) 94 (+3) 68 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/device_controller.go 63.24% (-0.54%) 272 (+7) 172 (+3) 100 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/dhcprelay_controller.go 65.28% (-0.61%) 265 (+7) 173 (+3) 92 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/dns_controller.go 60.69% (-0.90%) 145 (+7) 88 (+3) 57 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/ethernetsegment_controller.go 64.65% (-0.73%) 215 (+7) 139 (+3) 76 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/evpninstance_controller.go 61.83% (+0.26%) 262 (+7) 162 (+5) 100 (+2) 👍
github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller.go 71.45% (-0.88%) 592 (+10) 423 (+2) 169 (+8) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/isis_controller.go 61.67% (+1.55%) 180 (+7) 111 (+7) 69 👍
github.com/ironcore-dev/network-operator/internal/controller/core/lldp_controller.go 68.75% (-0.84%) 224 (+7) 154 (+3) 70 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/managementaccess_controller.go 57.24% (-0.73%) 145 (+7) 83 (+3) 62 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/ntp_controller.go 57.24% (-0.73%) 145 (+7) 83 (+3) 62 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller.go 66.82% (-2.63%) 223 (+7) 149 (-1) 74 (+8) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/ospf_controller.go 59.24% (-0.56%) 211 (+7) 125 (+3) 86 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/pim_controller.go 59.55% (-0.10%) 178 (+7) 106 (+4) 72 (+3) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/prefixset_controller.go 60.81% (-0.89%) 148 (+7) 90 (+3) 58 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller.go 65.66% (-1.88%) 198 (+7) 130 (+1) 68 (+6) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/snmp_controller.go 57.24% (-0.73%) 145 (+7) 83 (+3) 62 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/syslog_controller.go 57.43% (-0.72%) 148 (+7) 85 (+3) 63 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/user_controller.go 56.25% (-0.55%) 176 (+7) 99 (+3) 77 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/vlan_controller.go 61.15% (-0.85%) 157 (+7) 96 (+3) 61 (+4) 👎
github.com/ironcore-dev/network-operator/internal/controller/core/vrf_controller.go 61.38% (-0.94%) 145 (+7) 89 (+3) 56 (+4) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/provider.go 22.71% (ø) 207 47 160
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.39% (ø) 2037 8 2029
github.com/ironcore-dev/network-operator/internal/provider/openconfig/provider.go 0.00% (ø) 14 0 14
github.com/ironcore-dev/network-operator/internal/provider/provider.go 0.00% (ø) 47 (+22) 0 47 (+22)
github.com/ironcore-dev/network-operator/internal/provisioning/http.go 75.41% (-0.74%) 244 (+5) 184 (+2) 60 (+3) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/system_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/vpcdomain_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/acl_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/banner_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/bgp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/bgp_peer_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/certificate_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/device_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/dhcprelay_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/dns_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ethernetsegment_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/evpninstance_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/isis_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/lldp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/managementaccess_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ntp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ospf_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/pim_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/prefixset_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/snmp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/syslog_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/user_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/vlan_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/vrf_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provisioning/http_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant