Skip to content

Bump cert-manager to v1.21.0 and detect kind cluster in Tiltfile #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felix-kaestner wants to merge 1 commit into from
+5 −2
Open

Bump cert-manager to v1.21.0 and detect kind cluster in Tiltfile #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ setup-test-e2e: kind ## Set up a Kind cluster for e2e tests if it does not exist

# E2E test dependency versions
E2E_PROMETHEUS_OPERATOR_VERSION ?= v0.82.2
E2E_CERTMANAGER_VERSION ?= v1.17.2
E2E_CERTMANAGER_VERSION ?= v1.21.0

.PHONY: test-e2e
test-e2e: setup-test-e2e manifests generate ## Run the e2e tests. Expected an isolated environment using Kind.
Expand Down
5 changes: 4 additions & 1 deletion Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ watch_settings(ignore=['**/*/zz_generated.deepcopy.go', 'config/crd/bases/*'])

allow_k8s_contexts(['minikube', 'kind-network-operator'])

cluster_name = str(local('kubectl config current-context', quiet=True)).strip()
is_kind = cluster_name.startswith('kind-')

load('ext://cert_manager', 'deploy_cert_manager')
deploy_cert_manager(version='v1.18.2')
deploy_cert_manager(version='v1.21.0', load_to_kind=is_kind, kind_cluster_name=cluster_name.removeprefix('kind-'))

docker_build('controller:latest', '.', only=[
'api/', 'cmd/', 'internal/', 'go.mod', 'go.sum'
Expand Down
Loading