fix(interface): match labels against FQDN in LLDP validation#396
Open
nikatza wants to merge 1 commit into
Open
fix(interface): match labels against FQDN in LLDP validation#396nikatza wants to merge 1 commit into
nikatza wants to merge 1 commit into
Conversation
d0fce87 to
e3827bb
Compare
In this commit we change the validation of the label against the information received via LLDP. If DNS is configured on the remote device via a `DNS` Kubernetes resource, the interface controller fetches that resource and uses the `domain` field together with the device `hostname` to build an FQDN that is then compared to the LLDP systemName. This change now captures devices that export the FQDN in LLDP. Add DNS watch to interface controller for LLDP neighbor re-validation. When a DNS resource is created, deleted, or has its domain changed, interfaces with neighbor labels pointing to that device's interfaces are re-enqueued so LLDP adjacency validation re-evaluates the expected FQDN. Also fix SetLLDPNeighbor test helper to set ChassisIDType/PortIDType so LLDP adjacencies are no longer silently skipped in integration tests. Replace conditions-length heuristic in interfaceUpdatePredicate with explicit finalizer and deletion-timestamp checks. Adding a finalizer is a metadata-only change that no standard predicate (Generation, Label, Annotation) catches, so it falls to interfaceUpdatePredicate. The old len(conditions) < 4 guard happened to let these through because conditions are empty during bootstrap, but expressed the wrong invariant. The new checks explicitly pass the lifecycle transitions that the controller's multi-step bootstrap (finalizer → init conditions → reconcile) depends on. Signed-off-by: Pujol <enric.pujol@sap.com>
e3827bb to
88ca683
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit we change the validation of the label against the
information received via LLDP. If DNS is configured on the remote device
via a
DNSKubernetes resource, the interface controller fetches thatresource and uses the
domainfield together with the devicehostnameto build an FQDN that is then compared to the LLDP systemName. This
change now captures devices that export the FQDN in LLDP.
Add DNS watch to interface controller for LLDP neighbor re-validation.
When a DNS resource is created, deleted, or has its domain changed,
interfaces with neighbor labels pointing to that device's interfaces are
re-enqueued so LLDP adjacency validation re-evaluates the expected FQDN.
Also fix SetLLDPNeighbor test helper to set ChassisIDType/PortIDType so
LLDP adjacencies are no longer silently skipped in integration tests.
Replace conditions-length heuristic in interfaceUpdatePredicate with
explicit finalizer and deletion-timestamp checks. Adding a finalizer is
a metadata-only change that no standard predicate (Generation, Label,
Annotation) catches, so it falls to interfaceUpdatePredicate. The old
len(conditions) < 4 guard happened to let these through because
conditions are empty during bootstrap, but expressed the wrong
invariant. The new checks explicitly pass the lifecycle transitions that
the controller's multi-step bootstrap (finalizer → init conditions →
reconcile) depends on.