L3 subinterface configuration for Ciso NX-OS Provider by sven-rosenzweig · Pull Request #317 · ironcore-dev/network-operator

sven-rosenzweig · 2026-04-20T14:30:53Z

Implement basic CRUD for SubInterface resources:

Validate that the parent interface exists and is in a configured state before applying subinterface;
halt reconciliation otherwise
Ensure parent interface is Layer 3 (no switchport configuration)
Watch parent interface for create/update events to trigger reconciliation when it becomes available
Cascade deletion: removing the parent interface also deletes associated subinterfaces

To support the cascading deletion of interfaces, we set owner reference on subinterface to parent
interface. Omitting device owner reference on subinterface as this
blocks deletion until device gets deleted.

Add a new "subinterface" interface type to support Layer 3 subinterfaces. Layer 3 subinterfaces allow a single physical router interface to handle traffic from multiple VLANs by creating separate logical interfaces per VLAN. Validation rules: - Encapsulation is allowed for subinterfaces only - Supported encapsulation types: 802.1Q and 802.1ad - Validate VLAN ID range - 802.1ad requires two VLAN IDs (outer and inner VLAN) - Subinterfaces cannot be configured as aggregate, switchport, or vlanRef

felix-kaestner · 2026-04-20T14:39:53Z

+				CreateFunc: func(e event.CreateEvent) bool {
+					return true
+				},
+				UpdateFunc: func(e event.UpdateEvent) bool {
+					return false
+				},
+				DeleteFunc: func(e event.DeleteEvent) bool {
+					return false
+				},
+				GenericFunc: func(e event.GenericEvent) bool {
+					return false
+				},


Suggested change

CreateFunc: func(e event.CreateEvent) bool {

return true

},

UpdateFunc: func(e event.UpdateEvent) bool {

return false

},

DeleteFunc: func(e event.DeleteEvent) bool {

return false

},

GenericFunc: func(e event.GenericEvent) bool {

return false

},

UpdateFunc: func(e event.UpdateEvent) bool {

return false

},

GenericFunc: func(e event.GenericEvent) bool {

return false

},

This should trigger on create and delete events. Omitting the XFunc fields yields the default, which is true.

felix-kaestner · 2026-04-20T14:40:23Z

+		// Watches enqueues member of subinterfaces when their parent interface changes.
+		Watches(
+			&v1alpha1.Interface{},
+			handler.EnqueueRequestsFromMapFunc(r.physicalToSubinterfaces),


Suggested change

handler.EnqueueRequestsFromMapFunc(r.physicalToSubinterfaces),

handler.EnqueueRequestsFromMapFunc(r.parentToSubinterfaces),

Again, this is not only physical interfaces (but also aggregates).

felix-kaestner · 2026-04-20T14:42:11Z

+					Reason:  v1alpha1.ParentInterfaceNotReadyReason,
+					Message: fmt.Sprintf("referenced parent interface %q for not found", key),
+				})
+				return ctrl.Result{RequeueAfter: 0}, reconcile.TerminalError(fmt.Errorf("failed to get parent interface %q: %w", s.Interface.Spec.ParentInterfaceRef.Name, err))


Suggested change

return ctrl.Result{RequeueAfter: 0}, reconcile.TerminalError(fmt.Errorf("failed to get parent interface %q: %w", s.Interface.Spec.ParentInterfaceRef.Name, err))

return ctrl.Result{}, reconcile.TerminalError(fmt.Errorf("failed to get parent interface %q: %w", s.Interface.Spec.ParentInterfaceRef.Name, err))

The RequeueAfter: 0 should be omitted everywhere in this file.

felix-kaestner · 2026-04-20T14:43:19Z

+				conditions.Set(s.Interface, metav1.Condition{
+					Type:    v1alpha1.ConfiguredCondition,
+					Status:  metav1.ConditionFalse,
+					Reason:  v1alpha1.ParentInterfaceNotReadyReason,


Suggested change

Reason: v1alpha1.ParentInterfaceNotReadyReason,

Reason: v1alpha1.ParentInterfaceNotFoundReason,

I think this should be it's own reason.

felix-kaestner · 2026-04-20T14:43:52Z

 		}
 	}

+	var parentInterfaceRef *v1alpha1.Interface


Suggested change

var parentInterfaceRef *v1alpha1.Interface

var parentInterface *v1alpha1.Interface

This is not a ref. So this naming is a bit misleading.

felix-kaestner · 2026-04-20T14:55:07Z

+	Encap      string   `json:"encap"`
+	AdminSt    AdminSt2 `json:"adminSt,omitempty"`
+	Descr      string   `json:"descr"`
+}


Missing fields:

Suggested change

}

Medium Medium `json:"mediumType"`

RtvrfMbrItems *VrfMember `json:"rtvrfMbr-items,omitempty"`

felix-kaestner · 2026-04-20T14:55:29Z

+	ethernetRe     = regexp.MustCompile(`(?i)^(ethernet|eth)(\d+/\d+)$`)
+	loopbackRe     = regexp.MustCompile(`(?i)^(loopback|lo)(\d+)$`)
+	portchannelRe  = regexp.MustCompile(`(?i)^(port-channel|po)(\d+)$`)
+	subinterfaceRe = regexp.MustCompile(`(?i)^(ethernet|eth)(\d+/\d+)\.(\d+)$`)


Should also allow port-channel subinterfaces.

Might also rename this to encapRoutedRe in accordance with the struct.

felix-kaestner · 2026-04-20T14:58:20Z

+		}
+
+		v := "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)
+		s.Encap = v


Something like this would be missing for the missing fields:

Suggested change

s.Encap = v

if req.IPv4 != nil {

s.RtvrfMbrItems = NewVrfMember(name, vrf)

}

s.Medium = MediumBroadcast

if isPointToPoint(req.Interface.Spec.IPv4) {

s.Medium = MediumPointToPoint

}

felix-kaestner · 2026-04-20T14:59:33Z

+		v := "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)
+		s.Encap = v


Suggested change

v := "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)

s.Encap = v

s.Encap = "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)

No point in creating the variable first. Also, should this be a switch statement on the encap type? And what happens for QinQ subinterfaces?

felix-kaestner · 2026-04-20T15:00:48Z

These test files also have a golden file with the cli command producing this as {$filename}.txt:

interface eth1/1.100 encapsulation dot1q 100

Implement basic CRUD operations for SubInterfaces: * Validate that the parent interface exists and is in a configured state before applying subinterface; halt reconciliation otherwise * Ensure parent interface is Layer 3 (no switchport configuration) * Watch parent interface for create/update events to trigger reconciliation when it becomes available * Cascade deletion: removing the parent interface also deletes associated subinterfaces To support the cascading deletion of interfaces, we set owner reference on subinterface to parent interface. Omitting device owner reference on subinterface as this blocks deletion until device gets deleted.

github-actions · 2026-04-20T19:48:36Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1	0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core	63.75% (-0.04%)	👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos	10.15% (-0.02%)	👎

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go	0.00% (ø)	0	0	0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go	0.00% (ø)	0	0	0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go	0.00% (ø)	0	0	0
github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller.go	72.81% (-1.71%)	467 (+51)	340 (+30)	127 (+21)	👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go	18.88% (+0.44%)	143 (+2)	27 (+1)	116 (+1)	👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/name.go	54.17% (-0.38%)	24 (+2)	13 (+1)	11 (+1)	👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go	0.06% (-0.00%)	1660 (+21)	1	1659 (+21)	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller_test.go
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf_test.go

github-actions bot added the size/XL label Apr 20, 2026

sven-rosenzweig force-pushed the nxos/subinterface branch from 3ece646 to 95eaba0 Compare April 20, 2026 14:33

felix-kaestner reviewed Apr 20, 2026

View reviewed changes

sven-rosenzweig added 2 commits April 20, 2026 21:38

feat(nxos): Configure L3 interface

2452af5

sven-rosenzweig force-pushed the nxos/subinterface branch from 95eaba0 to e37cd2e Compare April 20, 2026 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L3 subinterface configuration for Ciso NX-OS Provider#317

L3 subinterface configuration for Ciso NX-OS Provider#317
sven-rosenzweig wants to merge 3 commits intomainfrom
nxos/subinterface

sven-rosenzweig commented Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

felix-kaestner Apr 20, 2026

Uh oh!

github-actions bot commented Apr 20, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	handler.EnqueueRequestsFromMapFunc(r.physicalToSubinterfaces),
	handler.EnqueueRequestsFromMapFunc(r.parentToSubinterfaces),

	return ctrl.Result{RequeueAfter: 0}, reconcile.TerminalError(fmt.Errorf("failed to get parent interface %q: %w", s.Interface.Spec.ParentInterfaceRef.Name, err))
	return ctrl.Result{}, reconcile.TerminalError(fmt.Errorf("failed to get parent interface %q: %w", s.Interface.Spec.ParentInterfaceRef.Name, err))

	Reason: v1alpha1.ParentInterfaceNotReadyReason,
	Reason: v1alpha1.ParentInterfaceNotFoundReason,

	var parentInterfaceRef *v1alpha1.Interface
	var parentInterface *v1alpha1.Interface

	}
	Medium Medium `json:"mediumType"`
	RtvrfMbrItems *VrfMember `json:"rtvrfMbr-items,omitempty"`

-		s.Encap = v
+		if req.IPv4 != nil {
+			s.RtvrfMbrItems = NewVrfMember(name, vrf)
+		}
+		s.Medium = MediumBroadcast
+		if isPointToPoint(req.Interface.Spec.IPv4) {
+			s.Medium = MediumPointToPoint
+		}

		v := "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)
		s.Encap = v

	v := "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)
	s.Encap = v
	s.Encap = "vlan-" + strconv.FormatInt(int64(req.Interface.Spec.Encapsulation.Tag), 10)

Conversation

sven-rosenzweig commented Apr 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 20, 2026

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants