Skip to content

[#600] prevent case-sensitive testing with BETWEEN where infeasible #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-w-moore wants to merge 3 commits into
base: main
Choose a base branch
from
+0 −24
Open

[#600] prevent case-sensitive testing with BETWEEN where infeasible #818

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c6e9f8
[_600] prevent case-sensitive testing with BETWEEN where infeasible
d-w-moore Apr 27, 2026
3402c7e
Revert "[_600] prevent case-sensitive testing with BETWEEN where infe…
d-w-moore Apr 29, 2026
77562a0
remove case-sensitive tests entirely.
d-w-moore Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions irods/test/query_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,30 +213,6 @@ def test_files_query_case_sensitive(self):
)
self.assertEqual(len(result12), 0)

# BETWEEN tests

# TODO(#600): Uncomment these lines and/or make a new test when database flavor can be detected.
# The resultset for BETWEEN queries can differ from database to database.

# result13 = self.sess.query(DataObject.name).filter(
# Collection.name == self.coll_path).filter(
# Between(DataObject.name, [self.case_sensitive_obj_name1,
# self.case_sensitive_obj_name1 + "_"])).all()
# self.assertTrue(result13.has_value(self.case_sensitive_obj_name1))
# self.assertEqual(len(result13), 1)

# result14 = self.sess.query(DataObject.name).filter(
# Collection.name == self.coll_path).filter(
# Between(DataObject.name, [str.lower(self.case_sensitive_obj_name1),
# str.lower(self.case_sensitive_obj_name1) + "_"])).all()
# self.assertEqual(len(result14), 0)

# result15 = self.sess.query(DataObject.name).filter(
# Collection.name == self.coll_path).filter(
# Between(DataObject.name, [str.upper(self.case_sensitive_obj_name1),
# str.upper(self.case_sensitive_obj_name1) + "_"])).all()
# self.assertEqual(len(result15), 0)

def test_files_query_case_insensitive(self):
# This tests that GenQueries are case-insensitive when the case_sensitive
# option is set to false.
Expand Down
Loading