Fix/multiserver vxlan clab link syntax - #3830
Open
sdargoeuves wants to merge 2 commits into
Open
Conversation
…links
The template emitted a mix of two incompatible containerlab link
syntaxes: an 'endpoints' list (brief/veth form) combined with the typed
'type: vxlan' form. containerlab rejects this while parsing the
topology file, so cross-server point-to-point links never deploy:
Failed to read topology file: yaml: unmarshal errors:
field endpoints not found in type struct { Type string; links.LinkVxlanRaw }
A typed VXLAN link takes a single 'endpoint' mapping, not an 'endpoints'
list -- the far end is described by 'remote' and 'vni'. The
'host:vx<vni>' pseudo-endpoint was never created either, and does not
match the name containerlab generates (vx-<node>_<iface>).
Link definitions have been parsed strictly since containerlab v0.44.0
and 'type: vxlan' has taken a singular 'endpoint' since v0.46.0, so the
unknown field is rejected rather than ignored on every supported
containerlab release.
Emit the endpoint mapping instead. The link type and the (deprecated but
still accepted) 'udp-port' key are left unchanged to keep the fix
minimal.
…ort' containerlab marks 'udp-port' as deprecated in LinkVxlanRaw in favour of 'dst-port', which pairs with the later 'src-port' option. Both keys are still accepted -- 'udp-port' is copied to 'dst-port' when only the former is set -- so this is a cosmetic change with no behaviour difference. 'dst-port' requires containerlab v0.70.0, which is below netlab's current minimum of 0.74.99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3829