Arista EOS netmiko configuration - #3827
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The EOS netmiko_error_regexp pattern as added is likely to miss configuration errors due to use of a start-of-string anchor without multiline matching.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds Netmiko-based configuration support for Arista EOS devices (vEOS/cEOS) by extending device defaults, enabling netlab_config_mode: netmiko, and documenting the new configuration method and caveats.
Changes:
- Add EOS Netmiko defaults (
netmiko_device_type,netmiko_error_regexp) and advertisenetmikoas a supportednetlab_config_modefor EOS (withshstill available for cEOS). - Update EOS normalization template to apply the relevant interface knob when using
netmikoas well assh. - Update platform documentation and caveats to link to vEOS/cEOS-specific EOS caveats and mention Netmiko configuration mode.
File summaries
| File | Description |
|---|---|
| netsim/devices/eos.yml | Adds EOS Netmiko defaults and enables netmiko config mode (and sh for cEOS). |
| netsim/ansible/templates/normalize/eos.j2 | Applies the PHY control-frame setting for netmiko in addition to sh. |
| docs/platforms.md | Documents Netmiko as an alternate deployment method for EOS and refines caveats links. |
| docs/caveats.md | Splits EOS caveats into vEOS/cEOS sections and documents Netmiko usage and effects. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.