fix(release-check): pass -version to gorelease#144
Open
lidel wants to merge 1 commit intoipdxco:mainfrom
Open
Conversation
Without -version, gorelease resolves the release candidate via MVS over the module graph instead of reading the working tree. When a dependency transitively requires an older version of the module being released (e.g. boxo depends on go-libp2p-kad-dht, which depends on boxo), MVS picks that older version as the candidate and the diff report comes out inverted, flagging all symbols introduced in the current release as "removed" and suggesting an unnecessary minor bump. Passing -version (already computed and validated via semver earlier in the workflow) forces gorelease to use the working tree as the candidate, restoring correct base-to-head comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes false-positive detection of breaking API changes which incorrectly suggested bump of version more than necessary.
Without
-version,goreleaseresolves the release candidate via MVS over the module graph instead of reading the working tree. When a dependency transitively requires an older version of the module being released (e.g. boxo depends on go-libp2p-kad-dht, which depends on boxo), MVS picks that older version as the candidate and the diff report comes out inverted, flagging all symbols introduced in the current release as "removed" and suggesting an unnecessary minor bump.Example: libp2p/go-libp2p-kad-dht#1245 (comment)
Passing
-version(already computed and validated via semver earlier in the workflow) forcesgoreleaseto use the working tree as the candidate, restoring correct base-to-head comparison.cc @galargh