Rewrite of delete_records_batch and is_record_locked functions#263
Open
chrisgitiota wants to merge 2 commits into
Open
Rewrite of delete_records_batch and is_record_locked functions#263chrisgitiota wants to merge 2 commits into
delete_records_batch and is_record_locked functions#263chrisgitiota wants to merge 2 commits into
Conversation
window_count_based(0) is now forbidden in favor of using window_none() instead to prevent silently misconfigured trails.
…ete-records-batch
itsyaasir
reviewed
May 20, 2026
| /// protect no records and is functionally identical to `window_none()`; | ||
| /// rejecting it at construction prevents silently misconfigured trails. | ||
| public fun window_count_based(count: u64): LockingWindow { | ||
| assert!(count > 0, ECountWindowMustBePositive); |
Contributor
There was a problem hiding this comment.
This is nice, and I think it will be nice to add this to our libraries for early returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_records_batch()andis_record_locked()functions.window_count_based(0)is now forbidden in favor of usingwindow_none()instead to prevent silently misconfigured trails.