docs(v9): update demos and support info to use v9 version - #4642
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
changed the title
There was a problem hiding this comment.
This looks great, the sweep itself is complete as far as I can tell, but need a couple of changes.
One thing that isn't from this PR but will cause us grief once v9 is live: vercel.json still redirects /docs/v8/:match* over to /docs/:match*, plus the ja equivalent. On this PR's preview there are 326 /docs/v8/ URLs in the sitemap and every one I tried 308s to the v9 page instead. I think we want to drop both lines and add /docs/v9/:match* versions so links against the new current version still land somewhere.
| }, | ||
| "node_modules/@ionic/core": { | ||
| "version": "8.8.16-dev.11785274070.1b3387c9", | ||
| "version": "9.0.0", |
There was a problem hiding this comment.
Nothing to do here, just noting it for later. The lockfiles only moved the @ionic/* version strings, so @ionic/core still lists the same @stencil/core dep it had under the old dev pin. Probably fine since that pin was already a major-9.0 build, but might be worth a real npm install in the four template dirs at some point, since these get copied straight into the generated StackBlitz project.
There was a problem hiding this comment.
Yeah we will want to test out the StackBlitz before we merge major-9.0.
Co-authored-by: Shane <shane@shanessite.net>
2 participants
latestfor the docusaurus build