Skip to content

fix(ci): declare yargs in data-sanitization devDependencies#311

Merged
ioncache merged 1 commit into
mainfrom
fix/yargs-pnp-dep
May 25, 2026
Merged

fix(ci): declare yargs in data-sanitization devDependencies#311
ioncache merged 1 commit into
mainfrom
fix/yargs-pnp-dep

Conversation

@ioncache
Copy link
Copy Markdown
Owner

@ioncache ioncache commented May 25, 2026

Overview

  • Fixes CI failure in the Update coverage report in Gist step introduced by the monorepo migration

Details

update-coverage-gist.mjs uses yargs, which was only declared in the root package.json. Yarn 4 PnP enforces strict dependency isolation — each workspace package can only access packages explicitly declared in its own package.json. Added yargs to packages/data-sanitization/devDependencies.

Related Tickets and/or Pull Requests

Relates to #308

Summary by CodeRabbit

  • Chores
    • Updated development dependencies in the data-sanitization package.

Review Change Stack

Yarn PnP requires each workspace package to declare its own deps.
The update-coverage-gist.mjs script uses yargs but it was only in
the root package.json, causing the CI gist update step to fail.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c0b7aaa-18b8-464f-8299-2204fb886326

📥 Commits

Reviewing files that changed from the base of the PR and between f99b825 and 3ce6b42.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/data-sanitization/package.json

📝 Walkthrough

Walkthrough

The PR adds yargs as a development dependency to the data-sanitization package alongside the existing vitest testing dependency. This is a minimal, configuration-only change to package.json.

Changes

Development Dependency Addition

Layer / File(s) Summary
Add yargs devDependency
packages/data-sanitization/package.json
The devDependencies object is updated to include yargs alongside the existing vitest dev dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through JSON's rows, ✨
With yargs now added to devs who code—
Commands made simple, arguments bright,
A tiny change, yet done just right! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding yargs to devDependencies in the data-sanitization package to fix a CI dependency issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/yargs-pnp-dep

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Coverage Report for packages/data-sanitization

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 171 / 171
🔵 Statements 100% (🎯 100%) 175 / 175
🔵 Functions 100% (🎯 100%) 22 / 22
🔵 Branches 100% (🎯 100%) 119 / 119
File CoverageNo changed files found.
Generated in workflow #240 for commit 3ce6b42 by the Vitest Coverage Report Action

@ioncache ioncache merged commit 7a44cfd into main May 25, 2026
5 checks passed
@ioncache ioncache deleted the fix/yargs-pnp-dep branch May 25, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant