fix(ui): stabilize workflow node execution state updates#9029
Open
JPPhoto wants to merge 2 commits intoinvoke-ai:mainfrom
Open
fix(ui): stabilize workflow node execution state updates#9029JPPhoto wants to merge 2 commits intoinvoke-ai:mainfrom
JPPhoto wants to merge 2 commits intoinvoke-ai:mainfrom
Conversation
05e1110 to
23fae17
Compare
23fae17 to
894df8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes workflow node execution state updates in the frontend event layer.
This change fixes nodes getting stuck in
IN_PROGRESSor showing duplicate outputs when socket events arrive out of order or are repeated. The fix moves the event-ordering logic into shared helpers and uses a listener-local completed-invocation key set so lateinvocation_started/invocation_progressevents cannot overwrite a completed node state.Related Issues / Discussions
QA Instructions
main, run a workflow in the Workflow Editor and examine the Outputs pane for a node that executes. You should see two outputs even when the node is executed once.pnpm vitest runto run regression tests.Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)